Thank you Nicolas and team for this great work.
Highly appreciated!!
I am facing some Exception related to VisualTheme while running the MRP.
https://demo-trunk.ofbiz.apache.org/manufacturing/control/RunMrp
I guess it is related to theme work we have done, please let me know, if I
am missing anything.
========= Console Log start =========
[[ASync service failed...- total:0.012,since last(ASync service
sta...):0.012]] - 'manufacturing / executeMrp'
2017-09-23 11:44:24,458 |jsse-nio-8443-exec-6
|ServiceDispatcher |E| Service [executeMrp] threw an unexpected
exception/error
org.apache.ofbiz.service.GenericServiceException: Problem serializing
service attributes (Cannot serialize object of class
org.apache.ofbiz.widget.renderer.VisualTheme)
at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:124)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:70)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
[ofbiz.jar:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
[ofbiz.jar:?]
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
[ofbiz.jar:?]
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
[ofbiz.jar:?]
at
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
[ofbiz.jar:?]
at
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:730)
[ofbiz.jar:?]
at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:454)
[ofbiz.jar:?]
at
org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
[ofbiz.jar:?]
at
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
[ofbiz.jar:?]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
[javax.servlet-api-3.1.0.jar:3.1.0]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
[javax.servlet-api-3.1.0.jar:3.1.0]
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
[tomcat-embed-websocket-8.0.39.jar:8.0.39]
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:196)
[ofbiz.jar:?]
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157)
[ofbiz.jar:?]
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:624)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
[tomcat-coyote-8.5.16.jar:8.5.16]
at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
[tomcat-coyote-8.5.16.jar:8.5.16]
at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
[tomcat-coyote-8.5.16.jar:8.5.16]
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
[tomcat-coyote-8.5.16.jar:8.5.16]
at
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
[tomcat-coyote-8.5.16.jar:8.5.16]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[?:1.8.0_66]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[?:1.8.0_66]
at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
[tomcat-util-8.5.16.jar:8.5.16]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
at
org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCustom(XmlSerializer.java:273)
~[ofbiz.jar:?]
at
org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(XmlSerializer.java:257)
~[ofbiz.jar:?]
at
org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(XmlSerializer.java:252)
~[ofbiz.jar:?]
at
org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(XmlSerializer.java:78)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:94)
~[ofbiz.jar:?]
... 40 more
2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
|TransactionUtil |I| Transaction rolled back
2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
|TransactionUtil |W| Not committing transaction, status is No
Transaction (6)
2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
|ServiceEventHandler |E| Service invocation error
org.apache.ofbiz.service.GenericServiceException: Problem serializing
service attributes (Cannot serialize object of class
org.apache.ofbiz.widget.renderer.VisualTheme)
at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:124)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:70)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
~[ofbiz.jar:?]
at
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
[ofbiz.jar:?]
at
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:730)
[ofbiz.jar:?]
at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:454)
[ofbiz.jar:?]
at
org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
[ofbiz.jar:?]
at
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
[ofbiz.jar:?]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
[javax.servlet-api-3.1.0.jar:3.1.0]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
[javax.servlet-api-3.1.0.jar:3.1.0]
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
[tomcat-embed-websocket-8.0.39.jar:8.0.39]
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:196)
[ofbiz.jar:?]
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157)
[ofbiz.jar:?]
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:624)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
[tomcat-catalina-8.5.16.jar:8.5.16]
at
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
[tomcat-coyote-8.5.16.jar:8.5.16]
at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
[tomcat-coyote-8.5.16.jar:8.5.16]
at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
[tomcat-coyote-8.5.16.jar:8.5.16]
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
[tomcat-coyote-8.5.16.jar:8.5.16]
at
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
[tomcat-coyote-8.5.16.jar:8.5.16]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[?:1.8.0_66]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[?:1.8.0_66]
at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
[tomcat-util-8.5.16.jar:8.5.16]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
at
org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCustom(XmlSerializer.java:273)
~[ofbiz.jar:?]
at
org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(XmlSerializer.java:257)
~[ofbiz.jar:?]
at
org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(XmlSerializer.java:252)
~[ofbiz.jar:?]
at
org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(XmlSerializer.java:78)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:94)
~[ofbiz.jar:?]
... 40 more
2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
|RequestHandler |E| Request runMrpGo caused an error with
the following message: Error calling event:
org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation
error (Cannot serialize object of class
org.apache.ofbiz.widget.renderer.VisualTheme)
2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
|RequestHandler |I| Rendering View [MrpExecution]. Hidden
sessionId by default.
2017-09-23 11:44:24,465 |jsse-nio-8443-exec-6
|ServiceDispatcher |T| Sync service
[manufacturing/getUserPreferenceGroup] finished in [1] milliseconds
========= Console log end =========
- Best Regards,
Swapnil M Mane
On Sun, Sep 10, 2017 at 4:21 PM, Michael Brohl <michael.br...@ecomify.de>
wrote:
> Thank you, Nicolas, for the great effort you put on this.
>
> I'll hope to soon reactivate my work on the bootstrap theme, using the new
> structure, and see how it will work out.
>
> I'll have some more qualified feedback (and propably questions ;-) )
> then...
>
> Thanks,
>
> Michael
>
>
> Am 25.08.17 um 12:15 schrieb Nicolas Malin:
>
> I loaded all my local :)
>>
>> Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
>>
>>> I started to load common-theme on trunk, at this time to resume :
>>>
>>> r1806075, r1806076 : I loaded engine and documentation
>>> r1806084 : I moved all images folder to common-theme
>>> r1806091, r1806093: I moved all ftl template from common to common-theme
>>> and all macro ftl libraries.
>>>
>> 1806134 : load VisualTheme and ModelTheme on different session and context
>> 1806137, 180614[0-9] : Migrate themes, common screens, handler to exploit
>> values from the theme definition
>> 1806150 : migrate all other screen and scripts to exploit values from
>> the theme definition
>> 180615 : improve error message and announce the commit end :)
>>
>> Cheers,
>> Nicolas
>>
>>>
>>> I hope to break nothing at this time.
>>> The next steps will load the dynamic theme load on session
>>>
>>> Cheers,
>>>
>>> Nicolas
>>>
>>>
>>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>>>
>>>> Hi Taher,
>>>>
>>>> If you have few time to have a look on these three class :
>>>>
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> model/ModelTheme.java
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> model/ThemeFactory.java
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> renderer/VisualTheme.java
>>>>
>>>> ModelTheme is java class to load all Theme definition who interact with
>>>> the system
>>>>
>>>> VisualTheme is java class regards the VisualTheme entity who interact
>>>> with the user to exploit the modelTheme
>>>>
>>>> ThemeFactory is the factory to create both.
>>>>
>>>> I prepare my commits, but I need to separate properly each code
>>>> modification to help other learn the work.
>>>>
>>>> Cheers,
>>>> Nicolas
>>>>
>>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>>>
>>>>> Hi Nicolas,
>>>>>
>>>>> If it helps you, I suggest to isolate files / code where you are not
>>>>> very comfortable and put them in a separate patch (not the full patch)
>>>>> with an explanation of what you've done and where you feel a little
>>>>> hesitant or uneasy. I think if you make us focus with you on very
>>>>> specific pieces of code then our review will be faster and your
>>>>> confidence of the review will be better.
>>>>>
>>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>>>> <nicolas.ma...@nereide.fr> wrote:
>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> I will commit on trunk after a second review of my code because i was
>>>>>> concentrated to increase the flexibility with macro and screen but not
>>>>>> manage correctly the VisualTheme concept.
>>>>>>
>>>>>> So I will take care about this, complete the documentation and commit
>>>>>> on
>>>>>> trunk.
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>>
>>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>>>
>>>>>>> Like Michael, I also prefer to include the work into the code base
>>>>>>> and
>>>>>>> test it over there. It seems like you put a lot of effort into this
>>>>>>> code so thank you! I like the fact that you brought all the artifacts
>>>>>>> into the theme along with the FTL macros. This is a good first step,
>>>>>>> and I believe continuing on this direction is where we need to go.
>>>>>>>
>>>>>>> +1 to committing into the code base and testing over there.
>>>>>>>
>>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>>>> <jacques.le.r...@les7arts.com> wrote:
>>>>>>>
>>>>>>>> That sounds great,
>>>>>>>>
>>>>>>>> Thanks Nicolas!
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>>>
>>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> I started the documentation here
>>>>>>>>>
>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>> themes/README.md
>>>>>>>>>
>>>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>>>
>>>>>>>>> Nicolas
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>>>
>>>>>>>>>> Hello;
>>>>>>>>>>
>>>>>>>>>> To continue the common-theme subject, I haven't see negative
>>>>>>>>>> return to
>>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads
>>>>>>>>>> on the
>>>>>>>>>> same
>>>>>>>>>> subject [2] and the additional theme xml definition [3], I
>>>>>>>>>> suggest to
>>>>>>>>>> create
>>>>>>>>>> a documentation on the wiki how work the "theme engine" and
>>>>>>>>>> commit the
>>>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>>>
>>>>>>>>>> After that, the engine will be present on the trunk and we
>>>>>>>>>> continue the
>>>>>>>>>> work to :
>>>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>>>
>>>>>>>>>> But don't panic, before that I'm listening to all suggest or
>>>>>>>>>> remarks ;)
>>>>>>>>>>
>>>>>>>>>> Nicolas
>>>>>>>>>>
>>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>>>> [2]
>>>>>>>>>>
>>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15
>>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>> [3]
>>>>>>>>>>
>>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab
>>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>>>>>>> [5]
>>>>>>>>>>
>>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...
>>>>>>>>>> nmalin:common-theme?expand=1
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>
>>>>
>>>
>>>
>>
>
>
