I wanted to thank you again for this work Nicolas. Hopefully with a little
more time and refinement we can purge all "web" stuff outside the framework
and make it a pure DSL infrastructure independent of the output technology.
This also opens the door for selecting front end technology stacks without
touching the core.
On Aug 25, 2017 3:35 PM, "Nicolas Malin" <nicolas.ma...@nereide.fr> wrote:
Hello
Le 25/08/2017 à 12:54, Deepak Dixit a écrit :
> Thanks Nicolas, Nice work.
>
Thanks Deepak, in line
I noticed some console warning while data load
> {quote}
>
> 2017-08-25 16:14:37,945 |main |UtilXml
> |E| XmlFileLoader: File
> file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight
> /widget/Theme.xml
> process error. Line: 20. Error message: TargetNamespace.2: Expecting no
> namespace, but the schema document has a target namespace of '
> http://ofbiz.apache.org/Widget-Theme'.
>
> 2017-08-25 16:14:37,946 |main |UtilXml
> |E| XmlFileLoader: File
> file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight
> /widget/Theme.xml
> process error. Line: 23. Error message: cvc-elt.1: Cannot find the
> declaration of element 'theme'.
>
> {quote}
>
Yes I detected it during my work, but I supposed to push the theme dtd on
the website will be solve it.
Else I will complete my knowledge with this mistake :)
Nicolas
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Fri, Aug 25, 2017 at 3:45 PM, Nicolas Malin <nicolas.ma...@nereide.fr>
> wrote:
>
> I loaded all my local :)
>>
>> Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
>>
>> I started to load common-theme on trunk, at this time to resume :
>>>
>>> r1806075, r1806076 : I loaded engine and documentation
>>> r1806084 : I moved all images folder to common-theme
>>> r1806091, r1806093: I moved all ftl template from common to common-theme
>>> and all macro ftl libraries.
>>>
>>> 1806134 : load VisualTheme and ModelTheme on different session and
>> context
>> 1806137, 180614[0-9] : Migrate themes, common screens, handler to exploit
>> values from the theme definition
>> 1806150 : migrate all other screen and scripts to exploit values from the
>> theme definition
>> 180615 : improve error message and announce the commit end :)
>>
>> Cheers,
>> Nicolas
>>
>>
>> I hope to break nothing at this time.
>>> The next steps will load the dynamic theme load on session
>>>
>>> Cheers,
>>>
>>> Nicolas
>>>
>>>
>>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>>>
>>> Hi Taher,
>>>>
>>>> If you have few time to have a look on these three class :
>>>>
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> model/ModelTheme.java
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> model/ThemeFactory.java
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> renderer/VisualTheme.java
>>>>
>>>> ModelTheme is java class to load all Theme definition who interact with
>>>> the system
>>>>
>>>> VisualTheme is java class regards the VisualTheme entity who interact
>>>> with the user to exploit the modelTheme
>>>>
>>>> ThemeFactory is the factory to create both.
>>>>
>>>> I prepare my commits, but I need to separate properly each code
>>>> modification to help other learn the work.
>>>>
>>>> Cheers,
>>>> Nicolas
>>>>
>>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>>>
>>>> Hi Nicolas,
>>>>>
>>>>> If it helps you, I suggest to isolate files / code where you are not
>>>>> very comfortable and put them in a separate patch (not the full patch)
>>>>> with an explanation of what you've done and where you feel a little
>>>>> hesitant or uneasy. I think if you make us focus with you on very
>>>>> specific pieces of code then our review will be faster and your
>>>>> confidence of the review will be better.
>>>>>
>>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>>>> <nicolas.ma...@nereide.fr> wrote:
>>>>>
>>>>> Thanks,
>>>>>>
>>>>>> I will commit on trunk after a second review of my code because i was
>>>>>> concentrated to increase the flexibility with macro and screen but not
>>>>>> manage correctly the VisualTheme concept.
>>>>>>
>>>>>> So I will take care about this, complete the documentation and commit
>>>>>> on
>>>>>> trunk.
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>>
>>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>>>
>>>>>> Like Michael, I also prefer to include the work into the code base and
>>>>>>> test it over there. It seems like you put a lot of effort into this
>>>>>>> code so thank you! I like the fact that you brought all the artifacts
>>>>>>> into the theme along with the FTL macros. This is a good first step,
>>>>>>> and I believe continuing on this direction is where we need to go.
>>>>>>>
>>>>>>> +1 to committing into the code base and testing over there.
>>>>>>>
>>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>>>> <jacques.le.r...@les7arts.com> wrote:
>>>>>>>
>>>>>>> That sounds great,
>>>>>>>>
>>>>>>>> Thanks Nicolas!
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>>>
>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> I started the documentation here
>>>>>>>>>
>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>> themes/README.md
>>>>>>>>>
>>>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>>>
>>>>>>>>> Nicolas
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>>>
>>>>>>>>> Hello;
>>>>>>>>>>
>>>>>>>>>> To continue the common-theme subject, I haven't see negative
>>>>>>>>>> return to
>>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on
>>>>>>>>>> the
>>>>>>>>>> same
>>>>>>>>>> subject [2] and the additional theme xml definition [3], I suggest
>>>>>>>>>> to
>>>>>>>>>> create
>>>>>>>>>> a documentation on the wiki how work the "theme engine" and commit
>>>>>>>>>> the
>>>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>>>
>>>>>>>>>> After that, the engine will be present on the trunk and we
>>>>>>>>>> continue the
>>>>>>>>>> work to :
>>>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>>>
>>>>>>>>>> But don't panic, before that I'm listening to all suggest or
>>>>>>>>>> remarks ;)
>>>>>>>>>>
>>>>>>>>>> Nicolas
>>>>>>>>>>
>>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>>>> [2]
>>>>>>>>>>
>>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15
>>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>> [3]
>>>>>>>>>>
>>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab
>>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>>>>>>> [5]
>>>>>>>>>>
>>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...
>>>>>>>>>> nmalin:common-theme?expand=1
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>
>>>
