Hi Renuka, I would also prefer to remove this condition as it's not making sense to keep order in created status when all the order items get canceled.
Thanks!! Regards, Ratnesh Upadhyay HotWax Systems | www.hotwaxsystems.com On Fri, Oct 6, 2017 at 12:52 PM, Deepak Dixit < deepak.di...@hotwaxsystems.com> wrote: > Hi Renuka, > > I see no reason to keen this condition. we can remove this. > As I know there is no business scenario around this. If all order item > cancelled than order should be cancel either its Sales or Purchase order. > > > > Thanks & Regards > -- > Deepak Dixit > www.hotwaxsystems.com > www.hotwax.co > > On Thu, Oct 5, 2017 at 7:17 PM, Renuka Srishti <renuka.srisht...@gmail.com > > > wrote: > > > Hello Devs, > > > > This is reference to > > http://markmail.org/message/wggbvdumrndpkxrj > > > > In "applications/order/src/org/ofbiz/order/order/OrderServices.java", > > under > > "checkItemStatus" service, there is one check for all item cancelled: > > > > if (!"PURCHASE_ORDER".equals(orderTypeId)) { > > newStatus = "ORDER_CANCELLED"; > > } > > > > I was trying to find out the reason behind it but did not get any. > > > > When we cancel all the items of an order, Order should cancel at the > header > > level too. Then why we have added this special check for purchase order? > > > > Becuase of this check, after canceling of all the items, purchase order > do > > not get canceled at the header level. Currently, we need to cancel the > > purchase order manually. > > > > > > Thanks > > Renuka Srishti > > >
