To make SO and PO flow consistent and to maintain order header status with its item status. Removed the condition, patch attached in OFBIZ-9838 <https://issues.apache.org/jira/browse/OFBIZ-9838>
Thanks Renuka Srishti On Mon, Oct 9, 2017 at 3:20 PM, Suraj Khurana < suraj.khur...@hotwaxsystems.com> wrote: > Thanks Renuka for bringing this into notice. > > I also agree with Arun's point > > -- > Best Regards, > *Suraj Khurana* | Sr. Enterprise Software Engineer > *HotWax Commerce * by *HotWax Systems* > Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 > > > On Mon, Oct 9, 2017 at 3:13 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Hi Renuka, > > > > It seems to have slipped in with http://svn.apache.org/viewvc?v > > iew=revision&revision=1026520 > > > > I see no reason to keep it > > > > Jacques > > > > > > > > Le 05/10/2017 à 15:47, Renuka Srishti a écrit : > > > >> Hello Devs, > >> > >> This is reference to > >> http://markmail.org/message/wggbvdumrndpkxrj > >> > >> In "applications/order/src/org/ofbiz/order/order/OrderServices.java", > >> under > >> "checkItemStatus" service, there is one check for all item cancelled: > >> > >> if (!"PURCHASE_ORDER".equals(orderTypeId)) { > >> newStatus = "ORDER_CANCELLED"; > >> } > >> > >> I was trying to find out the reason behind it but did not get any. > >> > >> When we cancel all the items of an order, Order should cancel at the > >> header > >> level too. Then why we have added this special check for purchase order? > >> > >> Becuase of this check, after canceling of all the items, purchase order > do > >> not get canceled at the header level. Currently, we need to cancel the > >> purchase order manually. > >> > >> > >> Thanks > >> Renuka Srishti > >> > >> > > >
