Mmm, it seems I wanted to say something here and pushed a button too fast :D
Actually I guess you saw this was done very simply at r1817040
Jacques
Le 24/11/2017 à 19:34, Jacques Le Roux a écrit :
Le 12/10/2017 à 22:12, Scott Gray a écrit :
Honestly I think the topic is generic enough that OFBiz doesn't need to
provide any information at all. Thread pool sizing is not exclusive to
OFBiz and it would be strange for anyone to modify the numbers without
first researching sources that provide far more detail than a few sentences
in our config files will ever cover.
Regards
Scott
On 12 October 2017 at 12:49, Michael Brohl<michael.br...@ecomify.de> wrote:
Hi Jacques,
yes, in general I think it's best to document at the place where users do
the configuration.
In this case, I cannot say if the statement makes any sense. It can be
from ancient times where you only had single core systems not making sense
anymore and it can also be correct today.
Maybe someone with more knowledege in this area can give us more info.
Regards,
Michael
Am 12.10.17 um 14:17 schrieb Jacques Le Roux:
Right, thanks Michael
Thought some documentation is present in ThreadPool.java, I think we
should document that at the service serviceengine.xml level
I mean, in general, we should document at the level used to configure,
not below.
Here for instance something like "Values higher than 5 might slow things
down depending of your cores numbers"
Also before written so we would have to verify why the 5 value was picked
What do you think?
Jacques
Le 12/10/2017 à 13:03, Michael Brohl a écrit :
Hi Jacques,
as you said, it's just a default and the value can be configured through
"max-threads".
I would leave it as is.
Regards,
Michael
Am 11.10.17 um 07:58 schrieb Jacques Le Roux:
MAX_THREADS = 5
