Hi Jacques, inline..
Am 05.01.18 um 08:31 schrieb Jacques Le Roux:
Hi,We have roughly 3514 variables created from properties, either from properties files or from DB values.Among them 53 are declared final, this does not make sense to me.
It might make sense depending on the business logic...
Because a variable which depends on a properties is cached and can be dynamically changed.You simply change the value in the properties file and clear the cache in webtools (either all caches or only the properties cache).So it's not a constant. We also use EntityUtilProperties, but same can happen with DB values, just change it and clear cache.
From the class view, this is wrong. If you declare a constant as a class variable from property files (e.g. as a final class attribute) the property is only read once and assigned to the final variable. You can change the variable in the properties or on the db and clear the cache, it will have no impact for the instantiated class.
If you want to freshly read the property value every time you need it and you want the possibility to change it dynamically at runtime, you'll have to read it in the respective code and cannot declare it once as a class attribute.
Because of that, IMO those variables should never be final, it's contradictory.What do you think?
I think that you cannot apply this as a general rule because it depends on how you want to use the property/variable. Taher has given a good example with the start component and there will be others.
So, -1 for applying this as a general rule, +1 for a thorough review of the 53 cases and changes where they make sense. Thanks, Michael
Jacques
smime.p7s
Description: S/MIME Cryptographic Signature
