Le 05/01/2018 à 08:45, Taher Alkhateeb a écrit :
-1

This is a perfect example of why mass-updates following a certain pattern
are a bad idea.
I did not say that all should be done. Of course every case should be checked.

The properties files in the start component define critical startup
parameters that cannot be changed without critically corrupting or even
crashing the system.
That's a good example where it should not be done

Therefore, I believe you should study each variable separately before
deciding if you are going to change it.
That was exactly my thoughts, I should have said it therefore. I have already 
quickly reviewed and in most cases they should be changed

Jacques


On Jan 5, 2018 10:31 AM, "Jacques Le Roux" <jacques.le.r...@les7arts.com>
wrote:

Hi,

We have roughly 3514 variables created from properties, either from
properties files or from DB values.

Among them 53 are declared final, this does not make sense to me.

Because a variable which depends on a properties is cached and can be
dynamically changed.

You simply change the value in the properties file and clear the cache in
webtools (either all caches or only the properties cache).

So it's not a constant. We also  use EntityUtilProperties, but same can
happen with DB values, just change it and clear cache.

Because of that, IMO those variables should never be final, it's
contradictory.

What do you think?

Jacques


Reply via email to