Done :)
Jacques
Le 11/11/2018 à 13:31, Mathieu Lirzin a écrit :
Hello Jacques,
Jacques Le Roux <jacques.le.r...@les7arts.com> writes:
So we would
remove ant-scripts folder and its content;
rename framework/base/groovyScript to framework/base/groovyScripts;
move GroovyInit.groovy and GroovyServiceTest.groovy to
framework/base/groovyScripts and change their paths where used.
And let GroovyBaseScript.groovy where it is
Right?
IMO since ‘GroovyBaseScript.groovy’ is not a java file it should not be
placed in:
./framework/service/src/main/java/org/apache/ofbiz/service/engine
but rather in:
./framework/service/src/main/groovy/org/apache/ofbiz/service/engine
Since Groovy is not configured in Gradle this might not work OOTB
because the ‘GroovyBaseScript’ will probably not be copied in
‘ofbiz.jar’ and not defined in the classpath of the MANIFEST.
However if we were to apply OFBIZ-10611 [1] which adds the Gradle Groovy
plugin for supporting unit tests written in Groovy beforehand, it should
work gracefully.
Otherwise looks good to me.
[1] https://issues.apache.org/jira/projects/OFBIZ/issues/OFBIZ-10611
