Hello, Here are two clarifications about removing the “component-load.xml” feature.
Michael Brohl <michael.br...@ecomify.de> writes: > Am 05.01.20 um 18:32 schrieb Mathieu Lirzin: > >> effectively optional (like the marketing example you brought) it should >> eventually be moved in the official plugins if we actually want to >> provides the capability for users to disable it. However users should > > Even it it would be a plugin, you still need a mechanism to > enable/disable it by configuration. > > To my understanding, if we use depends-on exclusively for framework, > applications and plugins, this would not be possible anymore. It depends if you consider modifying the “ofbiz-component.xml” as configuration or not. If yes there exists the “enabled” attribute of the <ofbiz-component> element which provides a mechanism to disable a component. > Am 06.01.20 um 10:29 schrieb Samuel Trégouët: > >> 1. component-load.xml in plugin directory seems to be feature (nobody >> discuss this point) > > That *might* be a misunderstanding (if Mathieu agrees on this > point). My understanding was that he first implemented and committed > the change for framework and applications (on Nov. 25). > > From his mail in dev [1] and also the issue title of [2] I understand > that the component-load mechanism should be removed *everywhere* > afterwards. The dev mail would not make sense otherwise because > already committed the work at the time of writing (two weeks before) > and he announces to go on if noone objects. > > I apologize if I missed a point here, maybe Mathieu can clarify this? Even if I advocate for superseding “plugins/component-load.xml” with <depends-on>, I recognize it as a feature (documented briefly in the README). You are correct that in [1] I did not mention that feature and focus on the removal of “framework/base/component-load.xml” which is another potential user-space configuration mechanism. I could have spoken about the “plugins/component-load.xml” feature too but at that time I thought it was less likely to matter than “framework/base/component-load.xml” because of the immaturity of the plugins mechanism and the long term existence of “framework/base/component-load.xml”. Does it clarify things? >> [1]: >> https://lists.apache.org/thread.html/c2612f1e296b6ea15872185871d3a9d83d6a4afc6d2a76f7a336a126%40%3Cdev.ofbiz.apache.org%3E >> [2]: >> https://lists.apache.org/thread.html/7eab3d2ae3bbeadb184b02f75f7b2b86263532485e88ecba4d4dc780%40%3Cdev.ofbiz.apache.org%3E -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
