Hi James, Thanks for your try, it's interesting to show involves generate by the compound widget.
Your commit without namespace has been more readable, it's good point. After If you want to continue, I imagine that convert a plugin like projectmgr or scrum would be a good place Nicolas On 17/06/2020 17:49, James Yong wrote: > Hi Nicolas, > > Removed the additional namespace as I agree they are a distraction. > > Agreed that plugin may be a better place to apply compound widgets, > as they are less likely being overriden by existing implementation. > Just find it to be troublesome moving between related elements while making > changes. > > So I will leave it for custom implementation then. > > Regards, > James > > On 2020/06/15 13:05:44, Nicolas Malin <nicolas.ma...@nereide.fr> wrote: >> Hi, >> >> Compound widget is interesting from my view in final component, where >> your code is closer than business cover so limited to reuse. >> >> For the "middle-ware" component, I have a doubt about the must valuable >> to convert it or how to convert it. To organize by compound widget maybe >> introduce to globalize by process and not by functional entities. >> >> After review your first commit [1] my feeling were decreased code >> visibility with the namespace representation, swaying with regroup all >> element that simplify the code navigation. Finally is that the problem >> to improve the code navigation throw ide plugin and keep each xml as low >> as possible (for the middle-ware component) and exploit compound widget >> on plugin to indicate another way to concentrate business code ? >> >> Nicolas >> >> [1] >> https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=blob;f=applications/order/widget/ordermgr/FindRequestCompound.xml;h=114e9c6d071a192d80e6278ba3e2c713f9ca1b17;hb=28809d7 >> >> On 14/06/2020 08:47, Jacques Le Roux wrote: >>> Hi James, >>> >>> I see you pushed changes for FindRequest. Maybe we should wait a bit >>> feedback from others? >>> >>> Jacques >>> >>> Le 14/06/2020 à 05:18, James Yong a écrit : >>>> Hi Jacques, >>>> >>>> Ok, I created OFBIZ-11821 for this. >>>> >>>> Regards, >>>> James >>>> >>>> On 2020/06/13 18:03:21, Jacques Le Roux >>>> <jacques.le.r...@les7arts.com> wrote: >>>>> Hi James, >>>>> >>>>> As a 1st thought I'd see no problem with that. >>>>> >>>>> Jacques >>>>> >>>>> Le 13/06/2020 à 14:32, James Yong a écrit : >>>>>> Hi all, >>>>>> >>>>>> Currently, compound widget tag is only used in Examples application. >>>>>> Propose to convert rest of the project to use compound widget, so >>>>>> that dependencies are grouped together. >>>>>> >>>>>> Regards, >>>>>> James
pEpkey.asc
Description: application/pgp-keys
