Hi Pritam, I concur: we should have separate repositories for each of the existing 3rd Party Solution Integrations (whether they be Fintech oriented, Logistics oriented or other).
With the removal of the existing integrations from ofbiz-framework, we reduce the footprint there (which is good), but putting them into ofbiz-plugins doesn't make a difference for adopters. They will get more than they may need. IMO, you could/should start with putting the code regarding the 'First Data Payment' integration plugin into a separate plugin. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since 2008 (without privileges) *Apache Trafodion <https://trafodion.apache.org>, Vice President* *Apache Directory <https://directory.apache.org>, PMC Member* Apache Incubator <https://incubator.apache.org>, committer Apache Steve <https://steve.apache.org>, committer On Mon, Jun 29, 2020 at 11:18 AM Pritam Kute <pritam.k...@hotwaxsystems.com> wrote: > Hello Pierre and all, > > IMO, we should have a separate OFBiz repository in which we can push the > third party integration code. > > Very soon we will start working on the ticket in which we are going to move > 3rd party payment integrations from applications to plugins [OFBIZ-7415]. > Instead of moving them to plugins, I would recommend using > a separate repository structure in which we can commit the 3rd party > integration plugins like payment gateways, SMS gateways, shipping gateways, > storefront integrations, etc. > > Let me know your thoughts. Pierre, please correct me if I am > missing anything here. > > Kind Regards, > -- > Pritam Kute > > > On Sun, Jun 28, 2020 at 1:59 PM Pierre Smits <pierresm...@apache.org> > wrote: > > > Hi all, > > > > Under ticket OFBIZ-11837 we saw Pritam made great strides forward in > > establishing a plugin for the 'First Data" Payment gateway in > > https://github.com/pritambkute/ofbiz-plugins, and subsequently > providing a > > PullRequest (and pulling it back again). > > > > I applaud Pritam for the initiative to bring a new feature set to the > > community of OFBiz adopters. > > > > But should we, as the OFBiz community, want any new 3rd *Solution > > Integration brought forward by a committer (or any other contributor) to > be > > included in the ofbiz-plugins repository? > > > > WDYT?? > > > > > > > > Met vriendelijke groet, > > > > Pierre Smits > > *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> > since > > 2008 (without privileges) > > > > *Apache Trafodion <https://trafodion.apache.org>, Vice President* > > *Apache Directory <https://directory.apache.org>, PMC Member* > > Apache Incubator <https://incubator.apache.org>, committer > > Apache Steve <https://steve.apache.org>, committer > > > > > > On Thu, Jun 25, 2020 at 7:48 AM Pritam Kute < > pritam.k...@hotwaxsystems.com > > > > > wrote: > > > > > Hello Devs, > > > > > > While integrating the First Data payment gateway with Apache OFBiz, we > > > found that the re-authorization request is supported by First Data only > > if > > > we send card security code (CVV) along with the card information. In > > other > > > payment gateways like Authorize.net, they allow the re-authorization > > > transactions without CVV. So we want to know the thoughts from the dev > > > community if we can add CVV as a mandatory/optional parameter while > doing > > > re-authorization. > > > > > > Also, we are going to implement token-based transaction capability with > > > First Data in which we will not be storing the customer's card > > information > > > in OFBiz instead it will be stored at First Data servers and they > return > > us > > > the token against that card data. That token can be used for further > > > transactions of that customer. Here we may need to introduce couple of > > new > > > entities or need to extend the existing OFBiz entities and a > configurable > > > setting at the product store level if the user wants to use the > > token-based > > > transactions or regular card transactions. > > > > > > Here we suggest a design in which we can extend > > ProductStorePaymentSetting > > > entity to provide an option to user to configure the token-based > > > transaction vs regular card-based transactions. Also, we can extend the > > > CreditCard entity and code to store the token returned from the payment > > > gateway for further transactions and display of saved card information > to > > > the customer (This we can fetch from payment gateways using the token > > > against the card). So if the user opts to token-based transactions, the > > > credit card data will not be stored in OFBiz in any case. This helps in > > > marking the website a PCI DSS compliant. We will put the overall design > > on > > > the ticket soon [1]. > > > > > > Let us know your thoughts/ideas to implement this feature. > > > > > > [1] https://issues.apache.org/jira/browse/OFBIZ-11841 > > > > > > Kind Regards, > > > -- > > > Pritam Kute > > > > > > On Thu, Jun 25, 2020 at 10:53 AM Pritam Kute < > > > pritam.k...@hotwaxsystems.com> > > > wrote: > > > > > > > Hello Devs, > > > > > > > > We have pushed the plugin for First Data payment gateway integration > > and > > > > raised PR for the same at > > > https://github.com/apache/ofbiz-plugins/pull/34 > > > > > > > > We are going to improve it further and add token-based transactions > to > > > > support PCI DSS compliance. We are going to make it configurable for > > the > > > > end-user. We have created a separate sub-ticket for these > improvements > > > > [OFBIZ-11841]. > > > > > > > > Kind Regards, > > > > -- > > > > Pritam Kute > > > > > > > > > > > > On Fri, Jun 19, 2020 at 2:01 PM Devanshu Vyas < > > vyas.devansh...@gmail.com > > > > > > > > wrote: > > > > > > > >> Hello Pritam, > > > >> > > > >> A nice initiative to move the custom gateway code from framework to > > > >> plugins. > > > >> I would like to extend my help to you for this task. > > > >> > > > >> Thanks & Regards, > > > >> Devanshu Vyas. > > > >> > > > >> > > > >> On Fri, Jun 19, 2020 at 1:19 PM Pritam Kute < > > > >> pritam.k...@hotwaxsystems.com> > > > >> wrote: > > > >> > > > >> > Thanks, Nicolas, and all devs for putting your thoughts. > > > >> > > > > >> > We will push the contribution as a separate plugin. Also, we would > > > like > > > >> to > > > >> > pick the task to move all custom gateways code from > > > >> framework/accounting to > > > >> > separate plugins for separate gateway implementations. This will > > > provide > > > >> > the facility to users to install the plugin of the payment gateway > > > which > > > >> > they want to use. > > > >> > > > > >> > We have created a new ticket in JIRA [OFBIZ-11837] for this > > > >> contribution. > > > >> > We will add some more sub tickets to deliver different payment > > > >> > gateway methods. > > > >> > > > > >> > Kind Regards, > > > >> > -- > > > >> > Pritam Kute > > > >> > > > > >> > > > > >> > On Tue, Jun 16, 2020 at 3:47 PM Aditya Sharma < > > > adityasha...@apache.org> > > > >> > wrote: > > > >> > > > > >> > > +1 Nicolas. Thanks Pritam for the proposal. > > > >> > > > > > >> > > Thanks and regards, > > > >> > > Aditya Sharma > > > >> > > > > > >> > > > > > >> > > On Tue, Jun 16, 2020 at 1:44 PM Jacques Le Roux < > > > >> > > jacques.le.r...@les7arts.com> wrote: > > > >> > > > > > >> > > > +1, Pierre Smits proposed that long ago, created Jira(s?) and > > even > > > >> > > > contributed for at least one plugin > > > >> > > > > > > >> > > > That can be found in Jira I hope Pierre will follow and gave > > > >> required > > > >> > > > information > > > >> > > > > > > >> > > > Jacques > > > >> > > > > > > >> > > > Le 16/06/2020 à 07:32, Suraj Khurana a écrit : > > > >> > > > > +1 Nicolas. > > > >> > > > > > > > >> > > > > -- > > > >> > > > > Best Regards, > > > >> > > > > Suraj Khurana > > > >> > > > > Senior Technical Consultant > > > >> > > > > > > > >> > > > > > > > >> > > > > On Mon, Jun 15, 2020 at 8:23 PM Nicolas Malin < > > > >> > > nicolas.ma...@nereide.fr> > > > >> > > > > wrote: > > > >> > > > > > > > >> > > > >> Hi Pritam, > > > >> > > > >> > > > >> > > > >> My preference go to move all gateway to plugin, to keep > OFBiz > > > >> > > framework > > > >> > > > >> slim and the connector quality high. > > > >> > > > >> > > > >> > > > >> If all third payment gateway are in plugin system, we are > > sure > > > >> that > > > >> > > the > > > >> > > > >> framework contains correct standard call in function > process, > > > >> and we > > > >> > > 're > > > >> > > > >> not tempted (to go fast) to introduce bad hook to support a > > > >> specific > > > >> > > > >> case needed by the gateway. > > > >> > > > >> > > > >> > > > >> That being said, your proposal to introduce this gateway > > > payment > > > >> are > > > >> > > > >> welcome :) > > > >> > > > >> > > > >> > > > >> Nicolas > > > >> > > > >> > > > >> > > > >> On 15/06/2020 15:15, Pritam Kute wrote: > > > >> > > > >>> Hello Devs, > > > >> > > > >>> > > > >> > > > >>> I hope everyone is safe and well. > > > >> > > > >>> > > > >> > > > >>> Apache OFBiz has OOTB integrations for most of the widely > > used > > > >> > > payment > > > >> > > > >>> gateways around the world. > > > >> > > > >>> > > > >> > > > >>> We are working on integrating First Data Payment Gateway > for > > > >> one of > > > >> > > the > > > >> > > > >>> websites. The First Data payment gateway is quite popular > > and > > > >> comes > > > >> > > in > > > >> > > > >> the > > > >> > > > >>> list of top payment gateways around the globe We would > like > > > to > > > >> > > > >> contribute > > > >> > > > >>> the basic payment gateway integration of First Data into > > > Apache > > > >> > > OFBiz. > > > >> > > > We > > > >> > > > >>> would like to know your thoughts on this. > > > >> > > > >>> > > > >> > > > >>> We would also like your opinion on contributing the > gateway > > > >> code in > > > >> > > > >>> applications/accounting component vs a separate plugin. > > > >> > > > >>> > > > >> > > > >>> After approval from the community, we will create detailed > > > >> tickets > > > >> > in > > > >> > > > >> JIRA > > > >> > > > >>> and contribute the patch accordingly. > > > >> > > > >>> > > > >> > > > >>> Thanks! > > > >> > > > >>> > > > >> > > > >>> Kind Regards, > > > >> > > > >>> -- > > > >> > > > >>> Pritam Kute > > > >> > > > >>> > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > > > > > > >
