Hi Nicolas, I wasn't aware of that constraint. Thanks for the insight.
Pierre Op do 29 jul. 2021 17:40 schreef Nicolas Malin <nicolas.ma...@nereide.fr>: > Hello, > > @Eugeu > > Yeah nice, I added some suggest to the PR, and create the linked jira > issue and we can push it on trunk > > @Pierre > > The service engine don't support an extension by plugins, you can't load > a new engine without change the framework. > > In this case I prefer to load the minimal quantity of code to > demonstrate an engine on the OFBiz framework instead of > > separate it in plugin and load it by apply a path or manually change the > configuration. > > Nicolas > > On 29/07/2021 10:58, Pierre Smits wrote: > > Hi Ioan, > > > > Would it not be better for the community to be able to implement this set > > of functionalities by means of a downloadable plugin? > > > > It seems to me that - in a way - this levels up to plugins like the > > indexing (lucene) or the REST plugins. Not every adopters would be keen > to > > have this by default OOTB. > > > > Best regards, > > Pierre Smits > > > > On Wed, Jul 28, 2021 at 10:23 PM Eugen Stan <eugen.s...@netdava.com> > wrote: > > > >> Hello Nicolas, > >> > >> Thanks for the suggestions. > >> I've made a PR for this: > >> https://github.com/apache/ofbiz-framework/pull/317 > >> > >> * has a service test > >> * has a service example > >> > >> > >> (defn echo-service > >> "Echo back all the parameters" > >> [dctx ctx] > >> (doto (new java.util.LinkedHashMap) > >> (.putAll ctx) > >> (.put ModelService/RESPONSE_MESSAGE ModelService/RESPOND_SUCCESS))) > >> > >> > >> On 07.07.2021 09:58, Nicolas Malin wrote: > >>> Hello, > >>> > >>> Thanks for this detail email and your works. > >>> > >>> I'm not opposed to load closure in OFBiz code base for same reason that > >>> you exposed. > >>> > >>> For success the inclusion, I suggest to rename the namespace to > >>> org.apache.ofbiz, add test one framework/service/testdef and an example > >>> "hello world" service. > >>> > >>> Thanks Eugen ! > >>> > >>> Nicolas > >> -- > >> Eugen Stan > >> +40720 898 747 / netdava.com > >> >
