[
https://issues.apache.org/jira/browse/OFBIZ-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569638#action_12569638
]
David E. Jones commented on OFBIZ-1648:
---------------------------------------
Could we back up a little on this? The main question is: what is the problem
you are trying to fix or the improvement you are trying to effect?
You mentioned the stuff you did "was a lot harder than it should have been",
but in what way, and how would these or other changes make those easier?
For example, using interfaces doesn't help if you don't want to substitute the
classes underneath. Why would we want to do that with ModelWidget? I haven't
reviewed this code for a while, but 'm not sure I even like the idea of the
ModelWidget class that the ModelForm, ModelScreen, etc extend from... or the
way the boundary comment stuff is implemented. It is possible to be too fancy
with genericizing things and get in your own way. In other words, object
oriented techniques of polymorphism and such can be wonderful, but sometimes a
direct approach is better and more flexible.
Whatever the case, the big point of most of the framework code in OFBiz is that
it support the higher level artifacts and do so in a stable, predictable way so
that the tools can be used with confidence and such. Sometimes too many
indirect approaches can actually make things more complex without adding any
benefit, thereby making things more error prone.
Please don't get me wrong, it's wonderful to see effort going into this code.
For the best experience with all of this I would recommend picking a direction
and making sure it's the right one before charting a course to it.
> Sandbox: Improved Screen Widgets, adding 3rd party rendering library support
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1648
> URL: https://issues.apache.org/jira/browse/OFBIZ-1648
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: widget_improvements.patch
>
>
> Discuss screen widget modifications and enhancements that will make the
> screen widgets more robust. Everyone is welcome to review and comment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
