[
https://issues.apache.org/jira/browse/OFBIZ-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570087#action_12570087
]
Adrian Crum commented on OFBIZ-1648:
------------------------------------
Jacques & David,
I think I understand David's remark about the widget boundary comments. My
approach was to put the boundary comments in the base class so that ALL widgets
have the potential of generating boundary comments. Each widget enables its own
boundary comments by calling a method in the base class. I did things this way
because it wasn't clear at the time which widgets the developer community
wanted to generate comments. I picked a handful that seemed relevant and waited
for feedback. So far no one has complained.
When I created the ModelWidget base class, I was also looking forward to future
requirements. Not too long ago, Anil requested that all widgets support the ID
attribute (which 3rd party rendering libraries use heavily). Having all widgets
extend a base class makes that easy to do.
As far as implementing the interfaces is concerned, it doesn't actually solve a
problem. Instead, it gives widget designers more options. One of the things
I've learned in two decades of working with application frameworks is you want
to give users of the framework plenty of options. With this patch, if a
developer wants to create a new screen widget, all they have to do is extend it
from the base ModelWidget class. If the developer finds the base ModelWidget
class too restricting they can write a class from scratch that implements the
WidgetModel interface. The bottom line is, the developer has options and isn't
locked into a preconceived way of how things should be done. On this issue,
David and I probably have a difference in design philosophy.
I'm going to drop the factory method code. It's too soon for it, and I'd rather
get the other aspects of the (forthcoming) patch committed, than have the whole
thing stalled because of a minor issue.
I appreciate David's review and remarks. Perhaps I tried to include too much in
a single patch, and that caused concern.
> Sandbox: Improved Screen Widgets, adding 3rd party rendering library support
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1648
> URL: https://issues.apache.org/jira/browse/OFBIZ-1648
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: widget_improvements.patch
>
>
> Discuss screen widget modifications and enhancements that will make the
> screen widgets more robust. Everyone is welcome to review and comment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
