[
https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584023#action_12584023
]
Mridul Pathak commented on OFBIZ-1722:
--------------------------------------
Nitin,
I looked at your patch but not tested it yet. Your patch looks fine. There
are some areas of improvements that I would like to suggest.
1) Some of the uiLabels are not defined in a standard way.
2) There are duplicate uiLabels. I think we can define most of the uiLabels in
Accounting component and just use them in Workeffort. Only the essential ones
must be defined in the WorkEffort.
3) In Menus.xml naming conventions of the newly added menus are not according
to the standard conventions.
Can you please find and fix these issues and attach an updated patch after a
good review and testing.
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in
> Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to
> Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an
> AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
