[ 
https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602639#action_12602639
 ] 

Mridul Pathak commented on OFBIZ-1722:
--------------------------------------

I have reviewed the attached patch.  Looks good to me.  There are two 
improvements:
1) Move property "WorkEffortWorkEffortAgreementAlreadyExist" from 
WorkEffortUiLabels.xml to AccountingUiLabels.xml and rename (should be 
AccountingAgreementWorkEffortApplAlreadyExists) it properly.  Also the 
corresponding changes to the createAgreementWorkEffortAppl will be needed to be 
done.
2) Value of the property "ListAgreementWorkEffortAppls" in 
AccountingUiLabels.xml must be plural.

Rest of the patch looks good.

> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
>                 Key: OFBIZ-1722
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1722
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, workeffort
>    Affects Versions: SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: AgreementWorkEffortAppls.patch, 
> AgrrementWorkEffortAppl.Patch, AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl.  This should go in 
> Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to 
> Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an 
> AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to