[
https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597825#action_12597825
]
Jacques Le Roux commented on OFBIZ-1780:
----------------------------------------
Hi Marco,
First of all, thanks for your hard work on this. I just checked your last
commit and found at least a problem I dreaded to face : inconsistent labels
between files, for instance EcommerceRating in Order and Ecommerce component.
This can be seen from 2 POVs :
1) These labels are simply inconsistent and, though we lost information in your
rewriting, it shoud not be a big deal to fix them.
2) This was done intentionally and the labels are not inconsistent but
overriden (as Adrian already outlined in
http://docs.ofbiz.org/display/OFBIZ/Tips+for+translation)
As you can see, it implies to look exhaustively in each use of each label to be
sure of their usages... That's why we should be very careful when doing this
task. There is no hurry and we can't afford to lose information. There is a
french(?) proverb which says "L'enfer est pavé de bonnes intentions" (hell is
paved with good intentions) very suitable in this case
(http://www.answers.com/topic/list-of-english-proverbs :o)
There are maybe more like this one, I did not check further
Thanks
> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
> Key: OFBIZ-1780
> URL: https://issues.apache.org/jira/browse/OFBIZ-1780
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce, order
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: cleanup_labels.patch, cleanup_labels2.patch,
> cleanup_labels3.patch, cleanup_labels4.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be
> converted to OrderXXX style and instead if they has been used by a specific
> application they will be converted to that specific style (OrderXXX or
> EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
