[ 
https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597836#action_12597836
 ] 

Jacques Le Roux commented on OFBIZ-1780:
----------------------------------------

Marco,

I agree that it's not obvious. Please, note however that my intent is to make a 
more general comment, anyway here is the example

As you can see in 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderUiLabels.xml?view=diff&r1=657556&r2=657557&pathrev=657557,
 previously we had
-    <property key="EcommerceRating">
-        <value xml:lang="de">Bewertung (1-5; 5 entspricht sehr gut)</value>
-        <value xml:lang="en">Rating (1-5; 5 being best)</value>
-        <value xml:lang="es">Voto (de 1 a 5)</value>
-        <value xml:lang="fr">Note(s) (de 1 à 5, 5 étant la meilleure)</value>
-        <value xml:lang="it">Posizione(1-5; 5 è il migliore)</value>
-        <value xml:lang="nl">Waardering (1-5; 5 is het beste)</value>
-        <value xml:lang="pt_PT">Classe (1-5; 5 para o melhor)</value>
-        <value xml:lang="ro">Pozitia(1-5; 5 este cea mai buna )</value>
-        <value xml:lang="ru">Рейтинг (1-5; 5 лучший)</value>
-        <value xml:lang="th">การประเมิณ (1-5; 5 คุณสมบัติดีที่สุด)</value>
-        <value xml:lang="zh">评级 (1-5; 5最好)</value>
-    </property>
In Order component and this was used in Ecommerce as you can see in 
screenshot-1. Now we have only the poorer one (at least in french but there are 
other languages concerned) which was already in Ecommerce as you can see in 
screenshot-2. As I said my intent is to underline the kind of drawbacks we can 
get doing this delicate issue. I did not find the time yet to evaluate the work 
proposed by Bruno but maybe we should have a look to see if it can avoid this 
type of issues. But I doubt it's possible to do this automatically easily since 
it's seems a challenging task, even by hand, as I hope this comment proves it.

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch, cleanup_labels2.patch, 
> cleanup_labels3.patch, cleanup_labels4.patch, screenshot-1.jpg, 
> screenshot-2.jpg
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be 
> converted to OrderXXX style and instead if they has been used by a specific 
> application they will be converted to that specific style (OrderXXX or 
> EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to