Adrian,
I agree that it could be simplyfied using the setUserPreferences request,
thanks for the hint, I was also trying to understand how to rewrite it.
In any case, if we consider that in the Visual Theme form additional fields
could be added later like for example:
- Default number of rows to display in the FindScreens
- Specific colors for themes that allow the user to change them
- etc.

may be following the same pattern as done for the preferences form is not
wrong.
Don't you think so?


2008/7/31 Adrian Crum (JIRA) <[EMAIL PROTECTED]>

>
>    [
> https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618564#action_12618564]
>
> Adrian Crum commented on OFBIZ-1885:
> ------------------------------------
>
> Bruno,
>
> Thank you for your contribution. Your patch could be simplified by having
> the Visual Theme selection form call the setUserPreference request (found in
> common-controller.xml).
>
>
> > Selectable Visual Themes
> > ------------------------
> >
> >                 Key: OFBIZ-1885
> >                 URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> >             Project: OFBiz
> >          Issue Type: Improvement
> >          Components: framework
> >            Reporter: Adrian Crum
> >            Priority: Minor
> >         Attachments: theme_1.zip, visual_themes.patch,
> visual_themes.patch, VisualThemeSelection.patch
> >
> >
> > Implement entities, services, and UI artifacts to add support for
> selectable Visual Themes.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Reply via email to