[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619550#action_12619550
]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
Bruno,
Thank you for your continuing work on this. There are a few things that need to
be changed however.
I don't believe we need a default setting in a properties file. If an
installation wanted to have a different default theme, then they could replace
it in the VisualThemeResources entity.
The _NA_ UserLogin is needed to support a default global preferences setting
group.
The VT_SCREENSHOT resource is a great idea.
The no_screenshot.jpg file is an interesting idea, but it doesn't support
internationalization. Maybe we should just display text to indicate there is no
screen shot available, or have nothing at all.
Merging the two patches is a good idea. That will make it easier for others to
evaluate the feature.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip,
> visual_themes.patch, visual_themes.patch, visualtheme_merged.patch,
> VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable
> Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
