I wrote this
Index: framework/common/config/CommonUiLabels.xml
===================================================================
--- framework/common/config/CommonUiLabels.xml (revision 687584)
+++ framework/common/config/CommonUiLabels.xml (working copy)
@@ -1705,6 +1705,10 @@
<value xml:lang="zh_CN">�用</value>
<value xml:lang="zh">æ— æ•ˆ</value>
</property>
+ <property key="CommonDisplaying">
+ <value xml:lang="en">Displaying ${lowCount} - ${highCount} of
${total}</value>
+ <value xml:lang="fr">Affichage de ${lowCount} Ã ${highCount} sur
${total}</value>
+ </property>
<property key="CommonDistance">
<value xml:lang="ar">مساÙ?Ø©</value>
<value xml:lang="de">Distanz</value>
Index: framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java
===================================================================
--- framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java
(revision 687675)
+++ framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java
(working copy)
@@ -340,8 +340,11 @@
}
if (listSize > 0) {
- String ofLabel = UtilProperties.getMessage("CommonUiLabels", "CommonOf",
(Locale) context.get("locale"));
- writer.append(" <span class=\"tabletext\">" + (lowIndex + 1) + " - " + (lowIndex +
actualPageSize) + " "+ ofLabel + " "
+ listSize + "</span> \n");
+ @SuppressWarnings("unused") int lowCount = lowIndex + 1;
+ @SuppressWarnings("unused") int highCount = lowIndex +
actualPageSize;
+ @SuppressWarnings("unused") int total = listSize;
+ String commonDisplaying = UtilProperties.getMessage("CommonUiLabels",
"CommonDisplaying", (Locale)
context.get("locale"));
+ writer.append(" <span class=\"tabletext\">" + commonDisplaying +
"</span> \n");
}
if (highIndex < listSize) {
writer.append(" <a href=\"");
But I'm still unsure how to test it. Bilgin spoke about party manager -> fin
accounts but then you are in accouting and I guess I
miss some data he has.
Jacques
From: "Jacques Le Roux" <[EMAIL PROTECTED]>
I agree that only sentences should be translated. There are still plenty of
that in OFBiz :/ It would need a full review. On a
related topic I also mentionned the use <fail-message> in OFBiz OOTB recently
I will write a bad translation practices in Wiki ! Any suggestions is/will be
welcome
I will also rewrite this one as suggested...
Jacques
From: "Adrian Crum" <[EMAIL PROTECTED]>
We have discussed this in the past. There should be a UI label like
Displaying ${lowCount} - ${highCount} of ${total}
-Adrian
Adam Heath wrote:
[EMAIL PROTECTED] wrote:
+ String ofLabel = UtilProperties.getMessage("CommonUiLabels", "CommonOf",
(Locale) context.get("locale"));
+ writer.append(" <span class=\"tabletext\">" + (lowIndex + 1) + " - " +
(lowIndex + actualPageSize) + " "+ ofLabel
+ " " + listSize + "</span> \n");
}
if (highIndex < listSize) {
writer.append(" <a href=\"");
This is the wrong way to translate something. You don't translate a word, but
a phrase. Some languages have different ordering
of primary phrase components.
A - B of Y -> "%1 - %2 of %3", with args {lowIndex + 1, lowIndex +
actualPageSize, listSize}.
I'd do that, but I don't know the translation system in ofbiz.
ps: I'd probably go so far as to say that all single-word translation entries
currently in ofbiz are probably wrong.
