Re: svn commit: r886743 [1/4] - in /ofbiz/branches/addbirt: applications/accounting/webapp/accounting/WEB-INF/ applications/accounting/webapp/accounting/WEB-INF/actions/payment/ applications/accounting/webapp/accounting/payment/report/ applications/account...

[Scott Gray]

On 4/12/2009, at 1:05 AM, Hans Bakker wrote:

I am waiting for your first positive comment.....

All my comments are positive (or at least neutral), it's just your perception of them that is negative.

Did you look at the New Revision: 886087 where we solved your last
concerns?

Briefly and I liked the approach, I'll take another pass over the whole thing on the weekend.

If you want to review these commits why not check them in the birt
branch...there they are separated.

I'm not so concerned about myself but more for others and in particular people looking at the commit history in the future. The integration and the examples are completely different subject matters are should be treated as such when committing to the trunk regardless of how they've been committed to the branch.

Regards,
Hans

On Fri, 2009-12-04 at 00:27 +1300, Scott Gray wrote:

Hi Hans,

When all of this comes across to the trunk could please consider
separating it into at least two commits, one for the integration and
another for all this other stuff.  It'll make the commits a little


Thanks
Scott

HotWax Media
http://www.hotwaxmedia.com

On 4/12/2009, at 12:12 AM, hans...@apache.org wrote:

easier to read especially when people are looking at the commit history.

Author: hansbak
Date: Thu Dec  3 11:12:50 2009
New Revision: 886743

URL: http://svn.apache.org/viewvc?rev=886743&view=rev
Log:
some example Birt reports with selection forms in accounting ->
payment and order -> reports

Added:
  ofbiz/branches/addbirt/applications/accounting/webapp/accounting/
WEB-INF/actions/payment/PaymentReport.groovy   (with props)
  ofbiz/branches/addbirt/applications/accounting/webapp/accounting/
payment/report/
  ofbiz/branches/addbirt/applications/accounting/webapp/accounting/
payment/report/PaymentReport.rptdesign
  ofbiz/branches/addbirt/applications/order/webapp/ordermgr/WEB-INF/
actions/reports/OrderByChannel.groovy   (with props)
  ofbiz/branches/addbirt/applications/order/webapp/ordermgr/reports/
OrderByReferrer.rptdesign
  ofbiz/branches/addbirt/applications/order/webapp/ordermgr/reports/
OrderDiscountCodeReport.rptdesign
  ofbiz/branches/addbirt/applications/order/webapp/ordermgr/reports/
OrdersByChannel.rptdesign
  ofbiz/branches/addbirt/applications/product/script/org/ofbiz/
product/olap/FactServices.xml   (with props)
  ofbiz/branches/addbirt/applications/product/webapp/facility/WEB-
INF/actions/inventory/InventoryItemReport.groovy   (with props)
  ofbiz/branches/addbirt/applications/product/webapp/facility/
inventory/report/
  ofbiz/branches/addbirt/applications/product/webapp/facility/
inventory/report/InventoryReport.rptdesign
Modified:
  ofbiz/branches/addbirt/applications/accounting/webapp/accounting/
WEB-INF/controller.xml
  ofbiz/branches/addbirt/applications/accounting/widget/
AccountingMenus.xml
  ofbiz/branches/addbirt/applications/accounting/widget/
CommonScreens.xml
  ofbiz/branches/addbirt/applications/accounting/widget/
PaymentForms.xml
  ofbiz/branches/addbirt/applications/accounting/widget/
PaymentScreens.xml

  ofbiz/branches/addbirt/applications/order/entitydef/
entitygroup_olap.xml
  ofbiz/branches/addbirt/applications/order/entitydef/
entitymodel_olap.xml
  ofbiz/branches/addbirt/applications/order/script/org/ofbiz/order/
olap/FactServices.xml
  ofbiz/branches/addbirt/applications/order/webapp/ordermgr/WEB-INF/
controller.xml
  ofbiz/branches/addbirt/applications/order/widget/ordermgr/
ReportForms.xml
  ofbiz/branches/addbirt/applications/order/widget/ordermgr/
ReportScreens.xml
  ofbiz/branches/addbirt/applications/product/entitydef/
entitygroup_olap.xml
  ofbiz/branches/addbirt/applications/product/entitydef/
entitymodel_olap.xml
  ofbiz/branches/addbirt/applications/product/servicedef/
services_olap.xml
  ofbiz/branches/addbirt/applications/product/webapp/facility/WEB-
INF/controller.xml
  ofbiz/branches/addbirt/applications/product/widget/facility/
FacilityForms.xml
  ofbiz/branches/addbirt/applications/product/widget/facility/
FacilityScreens.xml
  ofbiz/branches/addbirt/applications/product/widget/facility/
ReportScreens.xml
  ofbiz/branches/addbirt/framework/bi/script/org/ofbiz/bi/
DimensionServices.xml

ofbiz/branches/addbirt/applications/order/data/ OrderPortletData.xml

--
Antwebsystems.com: Quality OFBiz services for competitive rates

smime.p7s
Description: S/MIME cryptographic signature