On 09/16/2010 01:37 PM, Adrian Crum wrote:
On 9/16/2010 8:18 AM, Jacques Le Roux wrote:
From: "Adrian Crum" <adri...@hlmksw.com>
This description of events isn't entirely true.

David didn't reject Andrew's design, the community in general felt
excluded from the design process. David simply asked that we discuss
the design before code was committed.

Yes exactly, thanks for clarifying Adrian, I knew I had left some points
behind

The security redesign was the outcome of that discussion. As far as I
know, David and I agreed on the final design, but interest in it fell
off. I ended up being the only person working on it. Since then, David
has included the security redesign in his new project.

I tought there were some stumbling blocks, notably when merging your
works.

We only disagreed on the workflow. David wanted to commit all the
changes at once and I wanted to commit them a little at a time.

Completely brand new code that doesn't touch anything else *at all* can be committed as a single large chunk. But if you need to alter a bunch of other stuff scattered all over, separate commits are better. It makes it easier to verify correctness, and helps in 4 years when you are trying to figure out why something is broken.

Reply via email to