[ 
https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096964#comment-13096964
 ] 

Jacques Le Roux commented on OFBIZ-4391:
----------------------------------------

Hi Paul,

Technically your patch looks good to me, but white spaces after (.

But could you explain why tax adjustments should be copied into *shipping 
groups*, whether your explanation would be technical or functional...
Also you mentionned "At this point, there is just one ship group.", do you mean 
only 1 ship group is handled for now?

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the 
> order-wide adjustments for the shopping cart. Tax adjustments should be 
> copied into the shipping group, i.e. treated in a different way from 
> adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to