[
https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097146#comment-13097146
]
Paul Foxworthy commented on OFBIZ-4391:
---------------------------------------
Hi Jacques,
Thanks for reviewing this.
My change is functional.
In the shopping cart, see where tax adjustments are stored :
https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java?hb=true#to4693
They're the itemTaxAdj collection in the CartShipItemInfo class. When you
directly enter an order using the shopping cart, tax adjustments are handled
correctly. Try adding a quote and in the quote manually add an adjustment for
sales tax. When you create an order based on a quote, the adjustment for the
sales tax is not put into the itemTaxAdj collection. The result is the tax does
not contribute to the total tax, it's treated as a non-tax adjustment.
In my comment regarding one ship group, all I was trying to say is that the
shopping cart is being created based on a quote. The user might choose to
create a second or even more ship groups *after* the transfer of data from the
quote has been done, but at the time we're actually doing the transfer, there
can't be more than one. So, my comment is not about a limitation, but rather
clarifying that there is no need to look for more than one ship group. In other
words, the line
CartShipInfo shipInfo = cart.getShipInfo(0);
is fine. There will not be more than one shipInfo object.
I've stripped trailing spaces and revised the comment in my patch.
> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
> Key: OFBIZ-4391
> URL: https://issues.apache.org/jira/browse/OFBIZ-4391
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: rev 1164344
> Reporter: Paul Foxworthy
> Priority: Minor
> Labels: cart, order, quote, tax
> Attachments: OFBIZ-4391_loadCartFromQuote.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the
> order-wide adjustments for the shopping cart. Tax adjustments should be
> copied into the shipping group, i.e. treated in a different way from
> adjustments like a discount.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
