[ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098542#comment-13098542 ]
Paul Foxworthy commented on OFBIZ-4391: --------------------------------------- Hi Jacques, I think I have a fix for the NPE. I'm building a unit test to demonstrate the flaw and demonstrate it fixed after the patch is applied. I'll be uploading a new patch and the unit test in a day or two. Feel free to work on something else in the meantime :-). Cheers Paul Foxworthy > loadCartFromQuote should put tax adjustments into the shipping group > -------------------------------------------------------------------- > > Key: OFBIZ-4391 > URL: https://issues.apache.org/jira/browse/OFBIZ-4391 > Project: OFBiz > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: rev 1164344 > Reporter: Paul Foxworthy > Assignee: Jacques Le Roux > Priority: Minor > Labels: cart, order, quote, tax > Attachments: OFBIZ-4391_loadCartFromQuote.patch, > OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > loadCartFromQuote is currently copying all adjustments from a quote into the > order-wide adjustments for the shopping cart. Tax adjustments should be > copied into the shipping group, i.e. treated in a different way from > adjustments like a discount. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira