On May 22, 2012, at 1:07 PM, Venkat Mangudi wrote: > Here is what I did. > > Took the output from RAT after it had marked the license files > distinguishing the files that need license Vs the others. All files that > did not have a license (and were not a binary file were marked with > !?????). Outof this lot, I assumed svg files did not need the license > considering that they were graphics files. I also removed derby/db.lck > files as well as .class files. > > From the remaining 1985, I just knocked off all files > under > /home/buildslave2/slave2/ofbiz-trunk/build/framework/images/webapp/images/jquery, > all 597 of them. > > 1. I now have an assorted bunch of files under /home/buildslave2/slave2/** > ofbiz-trunk/build/framework/**base/build/ as well. Should I be ignoring > them?
All the files under <component>/build/ folders are generated ones and should be ignored. I would suggest to run RAT in your local box on a clean OFBiz in order to avoid these false positives. Jacopo > 2. I assume xml, xsl, dtd, java, groovy, ftl files should have > the Apache License and will create a patch for each of them. > > As I come up with some other files that are not part of the above, I will > keep them for later and ask for help. > > Does this sound like a plan? > > --Venkat > > On Tue, May 22, 2012 at 4:17 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > >> Venkat, >> >> It's great to offer your help. I'm afraid though that you will no be aware >> of some specificities (like the ones I underlined below: all docbookc and >> jQuery files) >> So the 1st thing is to distinguish patterns in order to exclude them. For >> instance, >> all files under runtime should be neglicted >> those under >> /home/buildslave2/slave2/**ofbiz-trunk/build/framework/** >> base/build/gen-src >> are generated, etc. >> >> On the other hand files like >> JsLanguageFileMappingCreator.**java >> OnePageCheckoutOptions.groovy >> should have a license header... >> >> Also please be sure to work in the section which begins by >> >> Files with Apache License headers will be marked AL >> Binary files (which do not require AL headers) will be marked B >> Compressed archives will be marked A >> Notices, licenses etc will be marked N >> >> HTH >> >> >> Jacques >> >> From: "Venkat Mangudi" <venkatmang...@gmail.com> >> >>> There are about 1985 files without Apache License as per the RAT report. >>> Different types of file dtd, xsl, xml, groovy, java, js and some more. >>> >>> I should check each file and verify/add Apache License to it, right? Who >>> did this last time? Maybe I can get a few pointers. >>> >>> --Venkat >>> >>> On Sat, May 19, 2012 at 2:52 AM, Pierre Smits <pierre.sm...@gmail.com >>>> wrote: >>> >>> Jacques, >>>> >>>> The amended help files (regarding licence statement in both locale EN and >>>> NL, and improvements to content of locale in EN) including the >>>> associcated >>>> structure files are uploaded as a patch in >>>> https://issues.apache.org/**jira/browse/OFBIZ-4802<https://issues.apache.org/jira/browse/OFBIZ-4802> >>>> . >>>> >>>> Regards, >>>> >>>> Pierre >>>> >>>> 2012/5/18 Pierre Smits <pierre.sm...@gmail.com> >>>> >>>>> Jacques, >>>>> >>>>> I will amend immediately the help files for both EN and NL locales. >>>>> >>>>> Regards, >>>>> >>>>> Pierre >>>>> >>>>> >>>>> 2012/5/18 Jacques Le Roux <jacques.le.r...@les7arts.com> >>>>> >>>>>> BTW you don't have to worry about docbook. We already treated it >>>>>> seriously. A worry less... >>>>>> On the other hand we need to put an ASL2 license in all Help_*.xml >>>> files >>>>>> where it's missing (my fault when committing Pierre's work) >>>>>> All jQuery is of course also OK, etc. >>>>>> >>>>>> >>>>>> Jacques >>>>>> >>>>>> From: "Venkat Mangudi" <venkatmang...@gmail.com> >>>>>> >>>>>>> On Fri, May 18, 2012 at 8:53 PM, Jacques Le Roux < >>>>>>> >>>>>>> jacques.le.r...@les7arts.com> wrote: >>>>>>> >>>>>>> You have a dynamic (updated at each builbot - our CI - build) RAT >>>> report >>>>>>>> at >>>>>>>> http://ci.apache.org/projects/******ofbiz/rat-output.html<http://ci.apache.org/projects/****ofbiz/rat-output.html> >>>> < >>>> http://ci.apache.org/projects/****ofbiz/rat-output.html<http://ci.apache.org/projects/**ofbiz/rat-output.html> >>>>> >>>>>>>> <http:/**/ci.apache.org/**projects/ofbiz/**rat-output.**html<http://ci.apache.org/projects/ofbiz/**rat-output.html> >>>> < >>>> http://ci.apache.org/projects/**ofbiz/rat-output.html<http://ci.apache.org/projects/ofbiz/rat-output.html> >>>>> >>>>>>>>> >>>>>>>> >>>>>>>> Be careful, this must be interpreted with a grain of salt... >>>>>>>> >>>>>>>> >>>>>>>> Will get on it right away. Thank you... >>>>>>> >>>>>>> -- >>>>>>> Regards, >>>>>>> Venkat >>>>>>> >>>>>>> >>>>> >>>> >>>> >>> >>> >>> -- >>> Regards, >>> Venkat >>> >>> > > > -- > Regards, > Venkat
