From: "Jacques Le Roux" <j...@les7arts.com>
Ho I see, big mistake actually. I did not thought about the effect of this
default value when the manager-class is not set in
catalina-container. I think I should have used
org.apache.catalina.ha.session.StandardManager as default rather
Anyway StandardManager would be the same as empty string as you did, simply not
DeltaManager that I check.
Jacques
There should not be other side effects though.
Jacques
From: "Jacques Le Roux" <j...@les7arts.com>
BTW the reported issue was only in a cluster context or also with a sole server?
Jacques
From: "Jacques Le Roux" <jacques.le.r...@les7arts.com>
I will also have a look. I explained why I did so at
https://issues.apache.org/jira/browse/OFBIZ-4289.
Jacques
From: <jaco...@apache.org>
Author: jacopoc
Date: Tue Jun 19 17:14:14 2012
New Revision: 1351778
URL: http://svn.apache.org/viewvc?rev=1351778&view=rev
Log:
Setting a default value of DeltaManager was causing a side effect: the method
setWebContextObjects was always invoked with the
persistSerialized argument set to false; this was causing a series of issues
(including one reported recently happening when
two users login/logout to the same application from the same browser and visit
another application).
The commit when this bug was introduced is:
Author: jleroux
Date: Mon Jun 6 20:26:35 2011
New Revision: 1132749
and unfortunately the revision was backported to the release branches; the
commit may have introduced other issues but I can't
review it now.
Modified:
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
Modified:
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java?rev=1351778&r1=1351777&r2=1351778&view=diff
==============================================================================
--- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
(original)
+++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java
Tue Jun 19 17:14:14 2012
@@ -659,7 +659,7 @@ public class LoginWorker {
String mgrClassName = null;
try {
cc = ContainerConfig.getContainer("catalina-container",
configFile);
- mgrClassName = ContainerConfig.getPropertyValue(cc,
"manager-class",
"org.apache.catalina.ha.session.DeltaManager");
+ mgrClassName = ContainerConfig.getPropertyValue(cc, "manager-class",
"");
} catch (ContainerException e) {
Debug.logError(e, "No catalina-container configuration found in
container config!");
}
