Jacopo, using localhost is the way it should be. Like you are running unit tests on your local instance, you are running functional tests on your local instance. This patch is only adding a new testing type which is not existing today. It's why it is designed to be part of OFBiz as a new functionality and not an external component. In this case, a complete component would have been designed, and would not be so coupled with OFBiz.
Cheers, 2012/11/15 Jacopo Cappellato <jacopo.cappell...@hotwaxmedia.com> > Thank you Erwan, but the information below doesn't help me to change my > point of view: the fact that the contribution was made to be part of the > trunk and that we already have Junit tests integrated doesn't necessarily > imply that we have to add this new one. > What do other think about this topic? > > Jacopo > > On Nov 15, 2012, at 11:00 AM, Erwan de FERRIERES wrote: > > > I don't think this should be seen as an external component. The new > > implementation is made to be part of OFBiz, like the junit tests we have. > > The main issue for selenium integration was the license, there was some > > components not consistent with the ASL2. I used ivy to download the jars > > only if needed. > > > > Thanks for the review, I will look at the points you listed. > > > > Cheers, > > > > 2012/11/15 Jacopo Cappellato <jacopo.cappell...@hotwaxmedia.com> > > > >> Isn't it a good candidate for an external component (i.e. not bundled in > >> OFBiz and maintained by the OFBiz community)? I think we have already > >> discussed this topic some time ago and we concluded that > >> I also cursorily reviewed the patch and I have seen a series of issues > >> (e.g. hardcoded components name in framework code, hardcoded > "localhost", > >> bad formatting, misleading variable names like "component" rather than > >> "application" etc...). > >> > >> Jacopo > >> > >> On Nov 14, 2012, at 7:02 PM, Erwan de FERRIERES wrote: > >> > >>> Hi all, > >>> > >>> I'm planning on committing the patch in OFBIZ-4872 which will add > >> webdriver > >>> testing in OFBiz this week-end. > >>> Is that OK for everyone, or are there some issues with this ? > >>> > >>> Thanks, > >>> > >>> > >>> -- > >>> Erwan de FERRIERES > >> > >> > > > > > > -- > > Erwan de FERRIERES > > -- Erwan de FERRIERES
