[ 
https://issues.apache.org/jira/browse/OFBIZ-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493018#comment-14493018
 ] 

Nicolas Malin commented on OFBIZ-6146:
--------------------------------------

Christian I review your patch it's seems to be good, but two questions :
 * why use 
{code}
<display description="${groovy: if(ownerPartyNameViews[0].partyTypeId == 
'PERSON') ownerPartyNameViews[0].firstName + ' ' + 
ownerPartyNameViews[0].lastName else ownerPartyNameViews[0].groupName}"/>
{code}
instead of
{code}
            <display-entity entity-name="PartyNameView" 
description="${firstName} ${lastName} ${groupName}" key-field-name="partyId"/>
{code}
 * why don't adding missing UiLabels file that contains label like 
uiLabelMap.FormFieldTitle_unitCost

I like the idea to remove ftl by xml screen definition :)

> LookupInventoryItem not functional
> ----------------------------------
>
>                 Key: OFBIZ-6146
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6146
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Christian Carlow
>            Assignee: Nicolas Malin
>         Attachments: OFBIZ-6146.patch
>
>
> LookupInventoryItem is not functional.  The dropdown results are not 
> implemented and the popup is implemented by LookupInventoryItems.ftl which 
> lacks search options leading to empty results.
> This was encountered for OFBIZ-6145 for purchase return issuance which 
> employs the lookup.
> It should be implemented based on the existing lookups which use form widgets 
> rather than FTL files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to