[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284335#comment-15284335
]
Jacques Le Roux commented on OFBIZ-6783:
----------------------------------------
After applying the last patch and an "ant clean-all load-demo" I tried
# java -jar ofbiz.jar --testlist
# java -jar ofbiz.jar --testlist file=testing.txt mode=text
# java -jar ofbiz.jar --testlist file=testing.txt mode=ant
For 2 and 3 I get but the help. For 1 I get:
{code}
C:\projectASF-Mars\ofbiz>java -jar ofbiz.jar --testlist
Start.java using configuration file org/ofbiz/base/start/testlist.properties
Set OFBIZ_HOME to - C:/projectASF-Mars/ofbiz
Admin socket configured on - /127.0.0.1:10523
2016-05-16 11:17:25,827 |main |ContainerLoader
|I| [Startup] Loading containers from
C:/projectASF-Mars/ofbiz/framework/base/config/ofbiz-containers.xml for loaders
[testlist]
2016-05-16 11:17:26,001 |main |ContainerLoader
|I| Loading container: component-container
2016-05-16 11:17:26,011 |main |ComponentContainer
|I| Auto-Loading component directory : [C:/projectASF-Mars/ofbiz/framework]
[...]
2016-05-16 11:17:26,923 |main |ComponentContainer
|I| All components loaded
2016-05-16 11:17:26,923 |main |ContainerLoader
|I| Loaded container: component-container
2016-05-16 11:17:26,923 |main |ContainerLoader
|I| Loading component's container: testtools-container
2016-05-16 11:17:26,925 |main |ContainerLoader
|I| Loaded component's container: testtools-container
2016-05-16 11:17:26,927 |main |ContainerLoader
|I| [Startup] Starting containers...
2016-05-16 11:17:26,927 |main |ContainerLoader
|I| Starting container component-container
2016-05-16 11:17:26,927 |main |ContainerLoader
|I| Started container component-container
2016-05-16 11:17:26,927 |main |ContainerLoader
|I| Starting container testtools-container
Exception in thread "main" java.lang.NullPointerException
at java.io.File.<init>(Unknown Source)
at
org.ofbiz.testtools.TestListContainer.start(TestListContainer.java:111)
at
org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:440)
at org.ofbiz.base.start.Start.start(Start.java:166)
at org.ofbiz.base.start.Start.main(Start.java:100)
2016-05-16 11:17:44,934 |Thread-0 |ContainerLoader
|I| Shutting down containers
2016-05-16 11:17:44,934 |Thread-0 |ContainerLoader
|I| Stopping container testtools-container
2016-05-16 11:17:44,934 |Thread-0 |ContainerLoader
|I| Stopped container testtools-container
2016-05-16 11:17:44,934 |Thread-0 |ContainerLoader
|I| Stopping container component-container
2016-05-16 11:17:44,934 |Thread-0 |ContainerLoader
|I| Stopped container component-container
{code}
> Refactor the start component
> ----------------------------
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java and the start component
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important component, I will provide a patch to
> be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
