[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284404#comment-15284404
]
Jacques Le Roux commented on OFBIZ-6783:
----------------------------------------
Please remove this part from your patch
{code}
Index: framework/start/lib/commons-cli-1.3.1.jar
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: framework/start/lib/commons-cli-1.3.1.jar
===================================================================
--- framework/start/lib/commons-cli-1.3.1.jar (revision 0)
+++ framework/start/lib/commons-cli-1.3.1.jar (working copy)
Property changes on: framework/start/lib/commons-cli-1.3.1.jar
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+application/octet-stream
\ No newline at end of property
{code}
Else you get this
{code}
Buildfile: C:\projectASF-Mars\ofbiz\build.xml
dir-init:
copy-derby-props:
ofbiz-init:
build:
[echo] [build] ========== Start Building (Compile) ==========
build-dev:
build-framework:
init:
prepare:
[mkdir] Created dir: C:\projectASF-Mars\ofbiz\framework\start\build\classes
[mkdir] Created dir: C:\projectASF-Mars\ofbiz\framework\start\build\lib
classes:
[javac18] Compiling 12 source files to
C:\projectASF-Mars\ofbiz\framework\start\build\classes
[javac18] error: error reading
C:\projectASF-Mars\ofbiz\framework\start\lib\commons-cli-1.3.1.jar; error in
opening zip file
[javac18] 1 error
BUILD FAILED
C:\projectASF-Mars\ofbiz\build.xml:421: The following error occurred while
executing this line:
C:\projectASF-Mars\ofbiz\build.xml:438: The following error occurred while
executing this line:
C:\projectASF-Mars\ofbiz\macros.xml:39: The following error occurred while
executing this line:
C:\projectASF-Mars\ofbiz\framework\start\build.xml:53: Compile failed; see the
compiler error output for details.
Total time: 896 milliseconds
{code}
Better let people put the lib there themselves.
After putting back the lib by hand and doing and "ant clean build' I still get
the same error with
java -jar ofbiz.jar --testlist mode=ant
or
java -jar ofbiz.jar --testlist mode=text
With
java -jar ofbiz.jar --testlist file=runtime/test-list-build.xml
I now get this list
{quote}
base:basetests
entity:entitytests
minilang:MinilangTests
common:userlogintests
common:performfindtests
service:servicetests
widget:widgettests
party:partytests
party:partycontactmechtests
workeffort:workefforttests
product:catalogtests
product:facilitytests
product:productcosttests
product:groupordertests
product:producttagtests
manufacturing:productionruntests
accounting:accountingtests
accounting:paymenttests
accounting:paymentappltests
accounting:invoicetests
accounting:fixedassettests
order:finaccounttests
order:ordertests
order:custrequesttests
order:quotetests
order:shoppinglisttests
order:shoppingcarttests
marketing:marketingtests
lucene:lucenetests
assetmaint:assetmainttests
scrum:scrumtests
example:example-tests
{quote}
Not sure how this is useful...
> Refactor the start component
> ----------------------------
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java and the start component
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important component, I will provide a patch to
> be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
