[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284728#comment-15284728 ]
Jacques Le Roux commented on OFBIZ-6783: ---------------------------------------- OK, my bad I kept the old StartupCommand.java and StartupCommandUtil.java. I got it working using java -jar ofbiz.jar --testlist file=runtime/test-list-build.xml --testlist mode=ant It was surprising to me to have to put --testlist twice in the command line, but following the help made it clear (I guess a note about having the 2 --testlist options on the same line would help) I now understand your reluctance to remove it. I think all is clear now. > Refactor the start component > ---------------------------- > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: Upcoming Branch > Reporter: Taher Alkhateeb > Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)