At r1757579
I have removed obsolete information:
LICENSE file
jars have no longer paths files
Ant is no longer present the Version 1.1 of the ASL can be removed
NOTICE file
Ant is no longer present its notice can be removed
Log4J is no longer present its notice can be removed (log4j2 has not the same
constraint)
jpim is no longer present its notice can be removed
Jacques
Le 24/08/2016 à 16:23, jler...@apache.org a écrit :
Also forgot to report that Ant has lib\optional folder with 3 not documented
jars there.
So as long as it's optional you don't need to reference it in the LICENSE file.
We use OPTIONAL_LIBRARIES for that as a convenience to users.
Jacques
Le 24/08/2016 à 15:04, Jacques Le Roux a écrit :
OK, I did my homework and here is what I found. I looked at 3 TLPs: Tomcat, Ant
& JMeter last releases.
Globally they all document in their LICENSE files the external libs they use in
their source releases; but don't to so in their binary LICENSE files.
For instance Tomcat uses
org.apache.taglibs.standard.tlv and
org.apache.commons.daemon.support
in its binary release (not in source) but does not document it (same LICENSE file than in source release). I guess both class are used an optional
component (did not check).
Same for Ant about Ivy. I though did not find any reference to the libs referenced in their lib/libraries.properties file which it is a bit like
OFBiz using Gradle...
JMeter gives much references, a bit the way we currently do, but without paths since the libs are of course not in its source release. Paths are
given for JavaScript files or other not Java types (in their bin folder)
To summarize, it seems that we still need to put jars references in our LICENSE file. But since the libs are not in OFBiz source release anymore
but are downloaded by Gradle we can't use file paths.
2 things I still wonder about are:
1. Why Ant does not document the libs referenced in their
lib/libraries.properties file. It could be that they are not used OOTB (ie
optional) I did
not check that yet
2. If we need to document all the externals libs used by OFBiz or only the one
directly reference in build.gradle.
HTH
Jacques
Le 23/08/2016 à 11:42, Jacques Le Roux a écrit :
Right, it seems those days I'm working either too late or too early. I'll
double check all my assertions.
I'm though quite happy with what I have found. Notably how jMeter organises
external libs and documents it.
A such thing is mandatory when you use a tool like Maven or Gradle and want to
deliver binary releases.
Thanks for the review!
Jacques
Le 23/08/2016 à 11:23, Jacopo Cappellato a écrit :
Specifically I have checked the binary release of Tomcat 8.5.4
Jacopo
On Tue, Aug 23, 2016 at 11:22 AM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:
Jacques,
see my comments inline:
On Tue, Aug 23, 2016 at 11:06 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
[...] So it should have been
"Tomcat nothing on ecj jar (Eclipse.org) in binary release" same for
JMeter
Please double check: I have checked the binary release as well and the
license is there too.
Regards,
Jacopo
