Jacopo summarized this very nicely. So yeah I would say the code quality of code in this feature is good and can go to the code base, but let's stay open to the idea of refactoring which may affect it in the future. I am already doing some low level work in that area BTW
Cheers, Taher Alkhateeb On May 8, 2017 6:13 PM, "James Yong" <jamesy...@apache.org> wrote: > Hi Jacopo, > > Thank you for looking into the matter. > > Was just looking at loading standard web application due to one use-case, > but the issue of deploying OFBiz WAR was bought up. > > Just to reiterate that allowing standard web application now should not > impede efforts towards building OFBiz WAR later, unless there are plans to > remove CatalinaContainer entirely. Thank you. > > Kind Regards, > James > > On 2017-05-08 22:17 (+0800), Jacopo Cappellato <jacopo.cappellato@ > hotwaxsystems.com> wrote: > > Hi James, > > > > thanks for your design proposal and implementation: I have reviewed your > > patch in Jira and it looks good to me. > > As mentioned by Taher, in the future we may try to move away from the > OFBiz > > container driven startup process in order to make OFBiz more easily > > deployable in an application server; deploying application like you have > > described will be even easier if we will succeed. > > In the meantime, since it will take time and your approach is simple and > > effective, I think that we could commit your work. > > > > Regards, > > > > Jacopo > > > > On Fri, May 5, 2017 at 10:35 AM, James Yong <jamesy...@apache.org> > wrote: > > > > > Hi all, > > > > > > I am looking into allowing OFBiz to load standard web application where > > > there is no controller.xml and the jar files residing in web-inf/lib > folder. > > > > > > Proposing to add an attribute named 'type' to the 'webapp' tag at > > > ofbiz-component.xml, i.e. > > > > > > <webapp name="myapp" > > > type="standard" <--------------- new proposed attribute > > > title="Myapp" > > > server="myapp-server" > > > location="webapp/myapp" > > > mount-point="/myapp"/> > > > > > > This new attribute will help to differentiate standard web applications > > > from those in OFBiz, and allows Catalina Container to load them > accordingly. > > > When type="standard", will load as standard web application. > > > When type is empty, load according to OFBiz way. > > > > > > Any feedback is welcome. > > > > > > Regards, > > > James Yong > > > > > > > > >
