Hi James, hi Taher,in general, I think it's helpful to have the possibility to load applications the "Tomcat way". If you want to extend functionality by dropping a third party WAR without setting up another Servlet container it would be possible with this change. The patch seems to be lightweight and if there are no unwanted side effects, why not add it?
It's much easier to do it this way instead of making OFBiz ready to be deployed in any servlet container (I guess).
Best regards, Michael Am 07.05.17 um 09:23 schrieb Taher Alkhateeb:
Hi James, Is it correct to assume that the purpose of this solution is to allow you to login to OFBiz and other systems using a unified account? If the answer is yes, then doesn't it seem a little strange to have that service embedded inside OFBiz when it is serving other accounts of other systems? Sorry for the many questions :) just trying to wrap my ahead around your vision on this. Cheers, Taher On Sun, May 7, 2017 at 9:44 AM, James Yong <jamesy...@apache.org> wrote:Hi Taher, Thanks for the review. My use case is to run CAS SSO on OFBiz, to avoid another Tomcat instance. But I won't commit the patch if others doesn't need it. Regards, James Yong PS: I can run standard web application in earlier OFBiz versions. On 2017-05-07 14:09 (+0800), Taher Alkhateeb <slidingfilame...@gmail.com> wrote:Hi James, I saw the patch and it seems to be in proper order. However, the issue still remains of why and what. Your patch isessentiallyturning OFBiz into a partial web server by calling the "addWebapp()" method. You want to do that so you can put an external web application inside the code base to run side-by-side with OFBiz. What I understand from this is that you want to have two webapps running together, and then communicating with each other over the wire. In other words, we have almost no integration between the two applications. So I will try to ask this question in reverse: Why do you want to run a standard Tomcat webapp inside OFBiz? What do you want to "share"? Andalso,what is forcing to take the route of an independent webapp as opposed toanintegration solution on the API level? On Sat, May 6, 2017 at 7:17 PM, James Yong <jamesy...@apache.org> wrote:Created a JIRA issue and upload a patch at https://issues.apache.org/jira/browse/OFBIZ-9347 On 2017-05-06 19:27 (+0800), "James Yong"<jamesy...@apache.org> wrote:Thanks Taher. Those are the big pictures. For now, need to work on the smallerissues.So I will start with the patch for the loading of standard webapplication.Regards, James Yong On 2017-05-06 18:48 (+0800), Taher Alkhateeb <slidingfilame...@gmail.com>wrote:Hi James, I guess we can start discussing this at a more detailed level onceyouhavea PoC or more elaborate exploration of the exact "why" and "how".Allgoodinitiatives ! Cheers, Taher Alkhateeb On Sat, May 6, 2017 at 7:41 AM, James Yong <jamesy...@apache.org>wrote:Hi Taher, Thank you also for the thoughts shared in the 'Loading standardwebapplication' and opening the discussion. Instead of converting OFBiz fully into a single web application,isuggestwe can have build functions: 1. to compile OFBiz into a WAR. This build-WAR function isoptionalandused only when the developer needs to deploy OFBiz WAR in aseparateServlet Container. Only the necessary files will be added to theWARfile.2. For deployment to different SIT / UAT / Productionenvironment.3. Accessed through Screens with OFBiz standalone running. i amthinkingof a studio plugin but will discuss it another time. I haven't looked at Birt but i guess it can be embedded into anexistingweb application. Some apps like CAS SSO doesn't allow embeddingoutof thebox and has to be run as a standard web application. When using OFBiz WAR, any standard web applications dependencycan bedeployed alongside. So should be no problem to support theloading ofstandard web application in the plugins in OFBiz standalone. There should also be no impact if we add Tomcat SSO now. Whendeployed asOFBiz WAR, Tomcat SSO will be irrelevant. Any SSO requirementswillbespecific to the J2EE container or via another standard webapplication likeCAS SSO. But adding Tomcat SSO to OFBiz standalone, we can solvetheproblems listed in https://issues.apache.org/jira/browse/OFBIZ-6963Regards, James Yong On 2017-05-06 09:37 (+0800), Taher Alkhateeb <slidingfilame...@gmail.com>wrote:Hmmm, I'm not sure, but on first glance I'm not sure the bestwaytointegrate is by dropping in a war file? Maybe a more robustsolution istohave an integration with the engine on the API level andinstantiate itfrom within OFBiz within its own control servlet. For example,take alookat how BIRT is deployed. So yeah my proposal is more work, but a cleaner integrationsolutionIMHO.On Fri, May 5, 2017 at 8:06 PM, James Yong <jamesy...@apache.org>wrote:Hi Taher, I am trying to develop an OFBiz plugin that consists of a) Camunda workflow engine (published as a WAR); and b) OFBiz web app that make use of the workflow engine. Allowing OFBiz to load standard web applications will allowme toachievethe above setup using only 1 plugin, making things easy forend-users.Theyonly need to download that plugin, and not worry aboutdeployingtheCamunda workflow engine (published as a WAR) on his/her own,asthe WARfile can be downloaded automatically via gradle script duringOFBizstarting up. Regards, James Yong On 2017-05-05 18:07 (+0800), Taher Alkhateeb <slidingfilame...@gmail.com>wrote:This topic is very much linked to the previous thread thatyoustartedearleri "Tomcat SSO" so they might as well be one topic. Ithink Iansweredmost stuff in that thread. However, I would add that in my opinion, maybe it would besimplerif weavoid implementing it in this fashion (ofbiz webapp +standardwebapp)butinstead treat all of OFBiz as a single webapp byrefactoringthecatalinacontainer. Having two ways of doing the same thing isperhapsanaddedcomplexity and more cognitive load on people for no addedvalue thatIcanthink of. Unifying, on the other hand, would be a hugeaddedvalueIMO.My 2 cents .. and thank you for bringing up this discussion On Fri, May 5, 2017 at 11:35 AM, James Yong <jamesy...@apache.org>wrote:Hi all, I am looking into allowing OFBiz to load standard webapplicationwherethere is no controller.xml and the jar files residing inweb-inf/libfolder.Proposing to add an attribute named 'type' to the'webapp'tag atofbiz-component.xml, i.e. <webapp name="myapp" type="standard" <--------------- new proposedattributetitle="Myapp" server="myapp-server" location="webapp/myapp" mount-point="/myapp"/> This new attribute will help to differentiate standardwebapplicationsfrom those in OFBiz, and allows Catalina Container toloadthemaccordingly.When type="standard", will load as standard webapplication.When type is empty, load according to OFBiz way. Any feedback is welcome. Regards, James Yong
smime.p7s
Description: S/MIME Cryptographic Signature