Hi Taher
I tend to prefer rewriting old and messy mini-lang to proper groovy DSL
or java.
I fear that code generation from poor designed minilang (beside the
technical interest :) ) could lead to have a lot of bad java with a lot
of cleaning required.
Gil
Le 19/05/2017 à 15:15, Taher Alkhateeb a écrit :
My recommendation if you want to achieve something significant for this
task is the following:
- Focus first on services and tests, the bulk of messy minilang is living
there
- Maybe we shouldn't reinvent the wheel. We already have the minilang
parsing logic, why not just use it to convert everything to Java? Yeah it
might look a bit odd, but we can do a full migration of all minilang
scripts in one shot. Then we can slowly focus on cleanup.
On Fri, May 19, 2017 at 2:59 PM, Nicolas Malin <nicolas.ma...@nereide.fr>
wrote:
Hi Michael,
My preference go to convert the mini-lang to Groovy with the following
reason :
* Ensure the DSL cover all mini-lang functionnality and if not why
* Implement some services in groovy
* Do it manually at the beginning, convert automatically it's just a
nightmare if you are not sure that all functionality are convertible.
Cheers,
Nicolas
Le 19/05/2017 à 12:38, Michael Brohl a écrit :
Hi All,
according to the discussion in [1] and the Jira issue [2] we decided to
deprecate mini lang and migrate it to Java and/or Groovy code.
To help contributors finding the right approach for the migration, we
should define which mini lang code should be migrated to Java code, groovy
or some DSL (which has to be further developed).
I'd propose to generally migrate services, events and tests to Java code
to begin with.
There was also a proposal by Paul Foxworthy [3] to have an automatic
conversion between mini lang and groovy DSL. Maybe we can extend this to
generate Java code also?
Any ideas and approach to do this?
Happy to hear your opinions,
best regards,
Michael Brohl
ecomify GmbH
www.ecomify.de
[1] https://lists.apache.org/thread.html/253b41060a295b8ab68bc78
763cc129fc74b712cf776f8716022097f@%3Cdev.ofbiz.apache.org%3E
[2] https://issues.apache.org/jira/browse/OFBIZ-9350
[3] https://lists.apache.org/thread.html/6ce592d253c102e50f25f5f
2095dab1e9b7c54e48260b9e6d1cda9e1@%3Cdev.ofbiz.apache.org%3E
