Hi all,
Regarding to the mentioned anomalies: - I thought that the correct content of a licence header/file is more important part than its format. But to be safe the format should be adapted for the next release. - To (1)(c): Also I thought it is fine to have the ³third-party-licences² contained in the LICENSE document. See at [2]: "Apache releases should contain a copy of each license, usually contained in the LICENSE document." - To (2): You are right, the automatic generated DISCLAIMER slightly differ. But as far as I have seen at least all include the required DISCLAIMER text from [3]. IMHO there is no blocking issue in the list, it are more improvements for next release. So from me a "+1 Release this package as Apache Olingo 1.1.0 incubating" Kind regards, Michael On 22/01/14 17:47, "Francesco Chicchiriccò" <[email protected]> wrote: >On 22/01/2014 17:39, Francesco Chicchiriccò wrote: >> Hi, >> having in mind the release check list at [1], everything looks fine to >> me but: >> >> (1) NOTICE files anomalies: >> (a) in some artifacts (source-release, for example) "Copyright 2013" >> instead of "Copyright 2013-2014" is shown; >> (b) in some artifacts (again source-release) the file content have >> spaces at the line beginning (see [2] for appropriate formatting) >> (c) in binary artifacts (as jpa, but also some WAR files in dist) >> the file do not contain attributions (e.g. third-party notices for >> bundled libraries, see again [2]). >> >> (2) DISCLAIMER file content is not everywhere the same, and in general >> don't comply with [3], unless there has been some kind of approval >> from Incubator IPMC I am not aware of > >(3) Not sure whether reformatted license header is allowed (for example, >root pom.xml is not the same as per [4]). > >> Not sure all this is blocker for the release, so I won't give (yet) a >>-1. >> Mentors, WDYT? >> >> Regards. >> >> [1] http://incubator.apache.org/guides/releasemanagement.html#check-list >> [2] http://apache.org/legal/src-headers.html#notice >> [3] http://incubator.apache.org/guides/branding.html#disclaimers >[4] http://www.apache.org/legal/src-headers.html#headers > >>
smime.p7s
Description: S/MIME cryptographic signature
