On 23/01/2014 08:11, Bolz, Michael wrote:
Hi all,
Regarding to the mentioned anomalies:
- I thought that the correct content of a licence header/file is more
important part than its format. But to be safe the format should be
adapted for the next release.
Agree to see this as an improvement.
- To (1)(c): Also I thought it is fine to have the ³third-party-licences²
contained in the LICENSE document. See at [2]: "Apache releases should
contain a copy of each license, usually contained in the LICENSE document."
LICENSE is LICENSE, NOTICE is NOTICE, as reported by [2]: you can search
general@incubator ML archives for countless discussions about this.
As a rule of thumb, when you include a 3rd party library's license in
LICENSE (only if such license is enlisted as compatible with AL 2.0, as
you know), you need to put a copyright notice in NOTICE.
Naturally, this needs to be done only for artifacts effectively
including 3rd party libraries either in source or binary form.
See some examples of NOTICE files from other projects:
http://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X/legal/NOTICE.txt
http://svn.apache.org/repos/asf/syncope/trunk/legal_ext/NOTICE
http://svn.apache.org/repos/asf/wink/trunk/wink-assembly/apache-wink/binarydist/NOTICE
Further, when you include 3rd party source code, this also needs to be
performed for source releases;
http://svn.apache.org/repos/asf/bval/trunk/NOTICE
http://svn.apache.org/repos/asf/openjpa/trunk/NOTICE
This is the only point for which I am in doubt it could be blocker for
the release under vote: mentors, please express your opinion, thanks.
- To (2): You are right, the automatic generated DISCLAIMER slightly
differ. But as far as I have seen at least all include the required
DISCLAIMER text from [3].
At least I'd take as improvement to put in every artifacts the *same*
DISCLAIMER file.
IMHO there is no blocking issue in the list, it are more improvements for
next release.
So from me a "+1 Release this package as Apache Olingo 1.1.0 incubating"
Kind regards,
Michael
On 22/01/14 17:47, "Francesco Chicchiriccò" <[email protected]> wrote:
On 22/01/2014 17:39, Francesco Chicchiriccò wrote:
Hi,
having in mind the release check list at [1], everything looks fine to
me but:
(1) NOTICE files anomalies:
(a) in some artifacts (source-release, for example) "Copyright 2013"
instead of "Copyright 2013-2014" is shown;
(b) in some artifacts (again source-release) the file content have
spaces at the line beginning (see [2] for appropriate formatting)
(c) in binary artifacts (as jpa, but also some WAR files in dist)
the file do not contain attributions (e.g. third-party notices for
bundled libraries, see again [2]).
(2) DISCLAIMER file content is not everywhere the same, and in general
don't comply with [3], unless there has been some kind of approval
from Incubator IPMC I am not aware of
(3) Not sure whether reformatted license header is allowed (for example,
root pom.xml is not the same as per [4]).
Not sure all this is blocker for the release, so I won't give (yet) a
-1.
Mentors, WDYT?
Regards.
[1] http://incubator.apache.org/guides/releasemanagement.html#check-list
[2] http://apache.org/legal/src-headers.html#notice
[3] http://incubator.apache.org/guides/branding.html#disclaimers
[4] http://www.apache.org/legal/src-headers.html#headers
--
Francesco Chicchiriccò
Tirasa - Open Source Excellence
http://www.tirasa.net/
ASF Member, Apache Syncope PMC chair, Apache Cocoon PMC Member
http://people.apache.org/~ilgrosso/
