On 27/01/2014 07:41, Alan Cabrera wrote:
Sorry about the tardy review. Great job on wrapping up the release! A few
small points:
I think that these need an ASL:
odata2-sample/cars-annotation-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml
odata2-sample/cars-annotation-archetype/src/test/resources/projects/basic/archetype.properties
odata2-sample/cars-service-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml
odata2-sample/cars-service-archetype/src/test/resources/projects/basic/archetype.properties
We should probably update the rat configuration.
On Jan 22, 2014, at 8:39 AM, Francesco Chicchiriccò <[email protected]> wrote:
Hi,
having in mind the release check list at [1], everything looks fine to me but:
(1) NOTICE files anomalies:
(a) in some artifacts (source-release, for example) "Copyright 2013" instead of
"Copyright 2013-2014" is shown;
This should probably be fixed. IMO, the copyright should simply be removed.
[2] explicitly states
The top of each NOTICE file should include the following text, suitably
modified to reflect the product name and year(s) of distribution of the
current and past versions of the product:
Apache [PRODUCT_NAME]
Copyright [yyyy] The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
Why you think the copyright should be removed?
(b) in some artifacts (again source-release) the file content have spaces at
the line beginning (see [2] for appropriate formatting)
This can probably wait for the next release; good to have but not required.
(c) in binary artifacts (as jpa, but also some WAR files in dist) the file do
not contain attributions (e.g. third-party notices for bundled libraries, see
again [2]).
The third-party notices that should be in the NOTICE file are only those that
are required by the thrid-parties, otherwise they are left out. Are their any
that mean this stricter requirement?
Sure:
olingo-odata2-dist-jpa-incubating-1.1.0-RC01-jpa.zip and
org.eclipse.persistence-javax.persistence contain
javax.ws.rs-javax.ws.rs-api-2.0-m10.jar - CDDL, notice is required
according to paragraph 3.3 of such license
org.eclipse.persistence-javax.persistence-2.0.5.jar - EPL, notice is
required
Then there are the WAR artifacts from
olingo-odata2-dist-ref-incubating-1.1.0-RC01-ref.zip:
olingo-odata2-annotation-processor-ref-web-incubating-1.1.0-RC01.war
olingo-odata2-jpa-processor-ref-web-incubating-1.1.0-RC01.war
olingo-odata2-ref-web-incubating-1.1.0-RC01.war
I actually don't know if dist policies should be applied also to these
WAR files which are actually included in a release artifact
(olingo-odata2-dist-ref-incubating-1.1.0-RC01-ref.zip) rather than being
release artifacts themselves.
If so there are even more anomalies out there.
Anyway, I believe these NOTICE oddities are *blocker* for release - at
least for what I've learned in the months I've spent with Syncope at
incubator; anyway if I am the only one believing so, I have no problems
in providing my +-0.
(2) DISCLAIMER file content is not everywhere the same, and in general don't
comply with [3], unless there has been some kind of approval from Incubator
IPMC I am not aware of
They all look the same to me. Rewording it to match what’s in [3] can probably
wait for the next release; good to have but not required.
They *are* different:
olingo-odata2-dist-jpa-incubating-1.1.0-RC01-jpa.zip says
olingo-odata2-dist-jpa-incubating is an effort undergoing incubation at
the Apache Software
Foundation (ASF), sponsored by the Apache Incubator PMC.
[...]
olingo-odata2-dist-lib-incubating-1.1.0-RC01-lib.zip says
olingo-odata2-dist-lib-incubating is an effort undergoing incubation at
the Apache Software
Foundation (ASF), sponsored by the Apache Incubator PMC.
[...]
olingo-odata2-dist-ref-incubating-1.1.0-RC01-ref.zip says
olingo-odata2-dist-ref-incubating is an effort undergoing incubation at
the Apache Software
Foundation (ASF), sponsored by the Apache Incubator PMC.
[...]
olingo-odata2-parent-incubating-1.1.0-RC01-source-release.zip says
(correctly):
Apache Olingo is an effort undergoing incubation at the Apache Software
Foundation (ASF), sponsored by the Apache Incubator PMC.
Anyway, as said, this is not blocker for the release.
Regards.
Not sure all this is blocker for the release, so I won't give (yet) a -1.
Mentors, WDYT?
Regards.
[1] http://incubator.apache.org/guides/releasemanagement.html#check-list
[2] http://apache.org/legal/src-headers.html#notice
[3] http://incubator.apache.org/guides/branding.html#disclaimers
On 22/01/2014 15:56, Amend, Christian wrote:
Hi,
This is a call for a vote on Apache Olingo 1.1.0 incubating. The vote will be
open for 72 hours (it will close on Saturday 25/01/2014 on 17pm CET) and passes
if no vote is (-1).
[ ] +1 Release this package as Apache Olingo 1.1.0 incubating
[ ] -1 Do not release this package because...
The release candidate is available here:
http://people.apache.org/~chrisam/olingo2/1.1.0-RC01/
The release candidate has been signed through the key 475D9522 in:
http://keyserver.kjsl.org:11371/pks/lookup?search=0x475D9522&op=vindex
The release candidate is based on the sources tagged with 1.1.0-RC01:
https://git-wip-us.apache.org/repos/asf?p=incubator-olingo-odata2.git;a=commit;h=7faf4de6180d21733d20a2375e84d40387473ff9
and is based on the following commit id:
7faf4de6180d21733d20a2375e84d40387473ff9
The Olingo keys file can be found here:
https://dist.apache.org/repos/dist/release/incubator/olingo/KEYS
To perform a RAT check please use the following parameters:
mvn clean install -Pbuild.quality
This will assure that the RAT check is performed with the necessary excludes.
Release distribution files:
// compilable sources
olingo-odata2-parent-incubating-1.1.0-RC01-source-release.zip
olingo-odata2-parent-incubating-1.1.0-RC01-source-release.zip.asc
olingo-odata2-parent-incubating-1.1.0-RC01-source-release.zip.md5
olingo-odata2-parent-incubating-1.1.0-RC01-source-release.zip.sha
// javadoc distribution
olingo-odata2-dist-javadoc-incubating-1.1.0-RC01-javadoc.zip
olingo-odata2-dist-javadoc-incubating-1.1.0-RC01-javadoc.zip.asc
olingo-odata2-dist-javadoc-incubating-1.1.0-RC01-javadoc.zip.md5
olingo-odata2-dist-javadoc-incubating-1.1.0-RC01-javadoc.zip.sha
// odata lib distribution with dependencies
olingo-odata2-dist-lib-incubating-1.1.0-RC01-lib.zip
olingo-odata2-dist-lib-incubating-1.1.0-RC01-lib.zip.asc
olingo-odata2-dist-lib-incubating-1.1.0-RC01-lib.zip.md5
olingo-odata2-dist-lib-incubating-1.1.0-RC01-lib.zip.sha
// jpa processor distribution with dependencies
olingo-odata2-dist-jpa-incubating-1.1.0-RC01-jpa.zip
olingo-odata2-dist-jpa-incubating-1.1.0-RC01-jpa.zip.asc
olingo-odata2-dist-jpa-incubating-1.1.0-RC01-jpa.zip.md5
olingo-odata2-dist-jpa-incubating-1.1.0-RC01-jpa.zip.sha
// reference scenario war files with dependencies + Apache CXF
olingo-odata2-dist-ref-incubating-1.1.0-RC01-ref.zip
olingo-odata2-dist-ref-incubating-1.1.0-RC01-ref.zip.asc
olingo-odata2-dist-ref-incubating-1.1.0-RC01-ref.zip.md5
olingo-odata2-dist-ref-incubating-1.1.0-RC01-ref.zip.sha
// java annotation processor distribution with dependencies
olingo-odata2-dist-janos-incubating-1.1.0-RC01-janos.zip
olingo-odata2-dist-janos-incubating-1.1.0-RC01-janos.zip.asc
olingo-odata2-dist-janos-incubating-1.1.0-RC01-janos.zip.md5
olingo-odata2-dist-janos-incubating-1.1.0-RC01-janos.zip.sha
Best Regards,
Christian
--
Francesco Chicchiriccò
Tirasa - Open Source Excellence
http://www.tirasa.net/
ASF Member, Apache Syncope PMC chair, Apache Cocoon PMC Member
http://people.apache.org/~ilgrosso/
