[
https://issues.apache.org/jira/browse/OOZIE-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574721#comment-13574721
]
Alejandro Abdelnur commented on OOZIE-1200:
-------------------------------------------
Thanks Rohini, just a follow up on the URIHandler ones:
* on #22, #21 & #32
Sorry for insisting on this one, I think we should keep the APIs as simple as
possible:
The methods registerForNotification() & exists() should receive a context and
there should be a single signature of the exists().
The URIContext is a lightweight object so that is not an issue, and, in the
methods we are receiving a config and user we are 'creating' one in pieces. The
fact that HCAT and FS cache instance reinforces this, we don't have to worry.
And when we do optimization later (by grouping URIs) we don't end up with APIs
that don't apply.
* Extra comment, I think we could move the URIContext interface as an inner
interface of the URIHandler interface.
> Review of HCAT integration branch
> ---------------------------------
>
> Key: OOZIE-1200
> URL: https://issues.apache.org/jira/browse/OOZIE-1200
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator, docs
> Reporter: Alejandro Abdelnur
> Fix For: trunk
>
> Attachments: HCat-commandcoord-package-review.patch,
> HCat-depedency-cache-review.patch, HCat-dependency-package-review.patch,
> Hcat-service-util-tools-action-jms-packages-review-1.patch,
> Hcat-service-util-tools-action-jms-packages-review.patch,
> HCatSpec-comments.patch
>
>
> Given the number of commits (and fixes) that when into this branch, I think
> the best way to review it is by posting patches with comments through out the
> code. Then we can follow up the discussion as comments in this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
