[
https://issues.apache.org/jira/browse/OOZIE-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574901#comment-13574901
]
Rohini Palaniswamy commented on OOZIE-1200:
-------------------------------------------
Tucu,
I would really prefer keeping the two APIs. Having a single API and writing
code everywhere to confirm to the parameters of that API beats the purpose of
polymorphism. Even if it is a light weight object, having to construct that
object is unnecessary. Callers have to construct the URIContext and destroy it
after the exists call. Instead of repeating that code, it is better to have the
api which simplifies that. Even though I talked about grouping of all uris with
same scheme and getting a single URIHandler in future, currently we stop on the
first missing dependency and the other exists API makes sense.
URIContext interface - Do we have to do nested interfaces? If we end up using
it somewhere else later, then we will have to move it out like
LauncherException now.
> Review of HCAT integration branch
> ---------------------------------
>
> Key: OOZIE-1200
> URL: https://issues.apache.org/jira/browse/OOZIE-1200
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator, docs
> Reporter: Alejandro Abdelnur
> Fix For: trunk
>
> Attachments: HCat-commandcoord-package-review.patch,
> HCat-depedency-cache-review.patch, HCat-dependency-package-review.patch,
> Hcat-service-util-tools-action-jms-packages-review-1.patch,
> Hcat-service-util-tools-action-jms-packages-review.patch,
> HCatSpec-comments.patch
>
>
> Given the number of commits (and fixes) that when into this branch, I think
> the best way to review it is by posting patches with comments through out the
> code. Then we can follow up the discussion as comments in this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
