----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9175/#review16588 -----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java <https://reviews.apache.org/r/9175/#comment35179> File to be revereted. only has whitespace changes. trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java <https://reviews.apache.org/r/9175/#comment35180> File to be revereted. only has whitespace changes. trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsFilterXCommand.java <https://reviews.apache.org/r/9175/#comment35170> typo. Should be Filter trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsFilterXCommand.java <https://reviews.apache.org/r/9175/#comment35171> non-Javadoc comments should be removed trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java <https://reviews.apache.org/r/9175/#comment35172> rename to something like isFirst trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java <https://reviews.apache.org/r/9175/#comment35173> Can we do a separate condition for = (list size = 1) and IN clause trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java <https://reviews.apache.org/r/9175/#comment35174> Just thought about it. If you are using just appname filter, you should honour sequence id and max events also because there will be lot of events. So better to have one command that takes all the options (jobid, appname, maxevents and sequence id). trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java <https://reviews.apache.org/r/9175/#comment35176> Should probably go in some util class as this code is repeated in other places too trunk/docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/9175/#comment35177> tab instead of space trunk/docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/9175/#comment35178> workflow action id/coordinator action id - Rohini Palaniswamy On Feb. 13, 2013, 10:23 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9175/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 10:23 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1189 > > > This addresses bug OOZIE-1189. > https://issues.apache.org/jira/browse/OOZIE-1189 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1444336 > trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1444336 > trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1444336 > trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1444336 > > trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsFilterXCommand.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1444336 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1444336 > trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1444320 > > Diff: https://reviews.apache.org/r/9175/diff/ > > > Testing > ------- > > tested locally > > > Thanks, > > Ryota Egashira > >
