----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9175/#review16605 -----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java <https://reviews.apache.org/r/9175/#comment35229> Plus the two new constants are not used anywhere trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java <https://reviews.apache.org/r/9175/#comment35230> typo. should be sele*c*tStr trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java <https://reviews.apache.org/r/9175/#comment35232> so this means, from the command-line, we can pass comma-separated list of ids/appnames? trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java <https://reviews.apache.org/r/9175/#comment35233> should combined logic be rather AND? - Mona Chitnis On Feb. 13, 2013, 10:23 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9175/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 10:23 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1189 > > > This addresses bug OOZIE-1189. > https://issues.apache.org/jira/browse/OOZIE-1189 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1444336 > trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1444336 > trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1444336 > trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1444336 > > trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsFilterXCommand.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1444336 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1444336 > trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1444320 > > Diff: https://reviews.apache.org/r/9175/diff/ > > > Testing > ------- > > tested locally > > > Thanks, > > Ryota Egashira > >
