> On Feb. 14, 2013, 5:22 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java, lines > > 82-83 > > <https://reviews.apache.org/r/9175/diff/3/?file=258599#file258599line82> > > > > Just thought about it. If you are using just appname filter, you should > > honour sequence id and max events also because there will be lot of events. > > So better to have one command that takes all the options (jobid, appname, > > maxevents and sequence id).
yes, agreed with this change. enabled offset/len when jobid/appname filter used. > On Feb. 14, 2013, 5:22 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java, line 147 > > <https://reviews.apache.org/r/9175/diff/3/?file=258599#file258599line147> > > > > Should probably go in some util class as this code is repeated in other > > places too in case of workflow, parsing method is all in DagEngine, but it might not be good place for SLA thing. since this method is only used here, also no other util method, I just kept it as it is , going forward, as more util methods, we can add util class. - Ryota ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9175/#review16588 ----------------------------------------------------------- On Feb. 15, 2013, 8:32 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9175/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2013, 8:32 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1189 > > > This addresses bug OOZIE-1189. > https://issues.apache.org/jira/browse/OOZIE-1189 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1446424 > trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1446424 > > trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java > 1446424 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1446424 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1446424 > trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1446424 > > Diff: https://reviews.apache.org/r/9175/diff/ > > > Testing > ------- > > tested locally > > > Thanks, > > Ryota Egashira > >
