----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9602/#review17103 -----------------------------------------------------------
Comments only on event generation -ActionCheckX failaction() should have wfjob failure event -CoordRerun should have waiting event for coordinator action -Remove coord action events from CoordKill, CoordSuspend, CoordResume. (All this are coord job related commands which will queue specific workflow commands. All the wf commands will call CoordActionUpdate once they finish execution. The events should be generated only there to avoid duplicates) -All coord action events should have nominal time -We can waiting events for CoordPushDependency and CoordActionUpdate also. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java <https://reviews.apache.org/r/9602/#comment36183> Have a different JPA executor which only brings required fields like user and app-name trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java <https://reviews.apache.org/r/9602/#comment36184> This event is also generated at the end of command. Remove from here and else where in middle of command trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java <https://reviews.apache.org/r/9602/#comment36185> CoordJob shouldn't be null. If it is, the event shouldn't be constructed as 'user' is a must field for an event. trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java <https://reviews.apache.org/r/9602/#comment36186> I think we should not have wfaction error code and error message for a workflow job event. This can be done for a wf action event later. - Virag Kothari On Feb. 26, 2013, 3:01 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9602/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2013, 3:01 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1209 > WIP patch > > > This addresses bug OOZIE-1209. > https://issues.apache.org/jira/browse/OOZIE-1209 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1449977 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1449977 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1449977 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 1449977 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1449977 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1449977 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1449977 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java > 1449977 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > 1449977 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java > 1449977 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1449977 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1449977 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1449977 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1449977 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1449977 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionFailureEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionStartedEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionSuccessEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionWaitingEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/Event.java PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/SLAEvent.java PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobFailureEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobStartedEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobSuccessEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/CoordinatorEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/DummyCoordEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/DummyWFEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/SLAEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/WorkflowEventListener.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/9602/diff/ > > > Testing > ------- > > More unit tests to be added > > > Thanks, > > Mona Chitnis > >
