----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9602/#review17437 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java <https://reviews.apache.org/r/9602/#comment36985> i don't have strong opinion which one better, but wondering, instead of calling different methods (generateSuccessEvent, generateFailureEvent..), how about having generic generateEvent(Event, ActionBean, JobBean), and inside the method, do appropriate conditional branching based on event.AppType? trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java <https://reviews.apache.org/r/9602/#comment36987> # of dispatcher might be limited, but still seem a bit waste to loop through not relevant dispatchers, one option might be to keep mapping between Event type --> dispatcher? - Ryota Egashira On March 5, 2013, 2:31 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9602/ > ----------------------------------------------------------- > > (Updated March 5, 2013, 2:31 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1209 > WIP patch > > > This addresses bug OOZIE-1209. > https://issues.apache.org/jira/browse/OOZIE-1209 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java > 1452586 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1452586 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1452586 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1452586 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1452586 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1452586 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionFailureEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionStartedEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionSuccessEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionWaitingEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/Event.java PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/EventDispatcher.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/JobEventDispatcher.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/SLAEvent.java PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/SLAEventDispatcher.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobFailureEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobStartedEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobSuccessEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/CoordinatorEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/DummyCoordEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/DummyWFEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/SLAEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/WorkflowEventListener.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > PRE-CREATION > trunk/core/src/main/resources/oozie-default.xml 1452586 > trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/9602/diff/ > > > Testing > ------- > > More unit tests to be added > > > Thanks, > > Mona Chitnis > >
