> On March 27, 2013, 11:08 p.m., Mona Chitnis wrote: > > Making a note of review comments > > 1. Possibly rename "Status" in JobEvent class to "EventStatus" and the > > corresponding API to getEventStatus(), setEventStatus(), and retaining API > > getStatus(), setStatus() to "actual" job status. > > 2. Refactor JobEvent and SLAEvent classes into client package (since > > listeners on the client side need status api)
3. Remove 'CREATED' from list of event statuses. We are not tracking notifications for coordinator action materialization as of now, as it will create lot of noise. - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9602/#review18445 ----------------------------------------------------------- On March 27, 2013, 10:05 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9602/ > ----------------------------------------------------------- > > (Updated March 27, 2013, 10:05 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1209 > WIP patch > > > This addresses bug OOZIE-1209. > https://issues.apache.org/jira/browse/OOZIE-1209 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/event/Event.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1461403 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1461403 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1461403 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1461403 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1461403 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1461403 > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/JobEvent.java PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java > PRE-CREATION > trunk/core/src/main/resources/oozie-default.xml 1461403 > trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/9602/diff/ > > > Testing > ------- > > More unit tests to be added > > > Thanks, > > Mona Chitnis > >
