[
https://issues.apache.org/jira/browse/OOZIE-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046580#comment-14046580
]
Robert Kanter commented on OOZIE-1532:
--------------------------------------
Looks mostly good, just some minor things:
- In CoordJobGetActionsSubsetJPAExecutor, can you replace the String
concatenation with multiple {{append(...)}}? There's a few other places that
you didn't change that does this; can you fix those while you're at it?
- WorkflowJobQueryExecutor#getSelectQuery calls {{getLog(...)}} and then
doesn't use the log; can you remove this?
- In oozie-default, you set
{{oozie.service.PurgeService.purge.old.coord.action}} to {{false}} as the
default (this preserves the old behavior, right?) but in PurgeService, you
specify {{true}} as the default. This shouldn't actually be a problem, but it
would be best if these matched and were both {{false}}. In the future, we
hopefully won't have to worry about this with sort of thing with OOZIE-1890.
- In oozie-default.xml, can you make the description a little more
_descriptive_?
- In PurgeXCommand, you should be able to have the shorter constructor call the
longer constructor with {{false}} as the last argument, instead of duplicating
the code.
- In PurgeXCommand, you added some Log INFO statements to loadState() that seem
like they were probably meant for you when testing the code. Can you clean
these up? Though perhaps we should add a few log statements throughout this
class as there's otherwise no way to see what it did; can you do this?
- In the new test in TestPurgeXCommand, can you add code that shows that
calling PurgeXCommand with the property set to {{false}} does not purge
anything? That helps prove that the property is working properly.
- In the new test in TestPurgeXCommand, can you verify that the caught
JPAExecutorException are the correct JPAExecutorExceptions? Look at some of
the other tests where I verified the error code.
As a general point, the database guarantees will prevent Oozie from hitting a
race condition where it tries to get the workflows or coord actions for a
coordinator at the same time those are being deleted, right?
> Purging should remove completed children job for long running coordinator jobs
> ------------------------------------------------------------------------------
>
> Key: OOZIE-1532
> URL: https://issues.apache.org/jira/browse/OOZIE-1532
> Project: Oozie
> Issue Type: New Feature
> Reporter: Srikanth Sundarrajan
> Assignee: Bowen Zhang
> Attachments: oozie-1532.patch, oozie-1532.patch, oozie-1532.patch
>
>
> Specifically, this is for long running coordinator jobs with high frequency.
> all child workflows are never purged as the coord job is still running.
> Oozie server configuration that indicates how many coordinator actions
> frequency ticks to keep. By doing this it would be possible to purge running
> coord jobs. By default this would not be enabled and the current logic would
> remain.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
