----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23524/#review47835 -----------------------------------------------------------
Actually all the synchronized is not required at all. Please remove them. XLog.Info is thread local. core/src/main/java/org/apache/oozie/service/EventHandlerService.java <https://reviews.apache.org/r/23524/#comment84064> synchronized is not required core/src/main/java/org/apache/oozie/service/EventHandlerService.java <https://reviews.apache.org/r/23524/#comment84065> clearLogPrefix is not required after log statement core/src/main/java/org/apache/oozie/sla/service/SLAService.java <https://reviews.apache.org/r/23524/#comment84067> Why public? core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java <https://reviews.apache.org/r/23524/#comment84070> Can be combined into one assert as the pattern is fixed core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java <https://reviews.apache.org/r/23524/#comment84069> Can be combined into one assert as the pattern is fixed - Rohini Palaniswamy On July 15, 2014, 9:11 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23524/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 9:11 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1933 > https://issues.apache.org/jira/browse/OOZIE-1933 > > > Repository: oozie-git > > > Description > ------- > > See JIRA > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 6c075ab > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 5349b33 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 5b30fc0 > core/src/main/java/org/apache/oozie/sla/service/SLAService.java 2349329 > core/src/main/java/org/apache/oozie/util/LogUtils.java 723ac36 > core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > ffb25e7 > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 438f2c2 > core/src/test/java/org/apache/oozie/sla/TestSLAService.java 205bcd1 > core/src/test/java/org/apache/oozie/test/XTestCase.java e739ec3 > > Diff: https://reviews.apache.org/r/23524/diff/ > > > Testing > ------- > > added new tests and checked existing ones pass > > > Thanks, > > Mona Chitnis > >
